Skip to content

PurchaseTester: fixed compilation from verification API changes#2328

Merged
NachoSoto merged 1 commit into
mainfrom
purchase-tester-update
Mar 7, 2023
Merged

PurchaseTester: fixed compilation from verification API changes#2328
NachoSoto merged 1 commit into
mainfrom
purchase-tester-update

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@NachoSoto NachoSoto added the test label Mar 7, 2023
@NachoSoto NachoSoto requested a review from a team March 7, 2023 17:18
@codecov

codecov Bot commented Mar 7, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2328 (ca75f1d) into main (f5119bb) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   86.50%   86.45%   -0.05%     
==========================================
  Files         188      188              
  Lines       12750    12750              
==========================================
- Hits        11029    11023       -6     
- Misses       1721     1727       +6
Impacted Files Coverage Δ
...s/Purchasing/StoreKitAbstractions/Storefront.swift 57.14% <0.00%> (-5.36%) ⬇️
...rces/Purchasing/StoreKit1/ProductsFetcherSK1.swift 90.96% <0.00%> (-1.70%) ⬇️
Sources/Logging/Strings/PurchaseStrings.swift 88.65% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NachoSoto NachoSoto mentioned this pull request Mar 7, 2023
Merged
@NachoSoto NachoSoto merged commit 920f3fe into main Mar 7, 2023
@NachoSoto NachoSoto deleted the purchase-tester-update branch March 7, 2023 17:41
NachoSoto added a commit that referenced this pull request Mar 13, 2023
@NachoSoto
Made Configuration.EntitlementVerificationMode.enforced unavailable (…
3af5fba 
…#2329)

Depends on #2326 and #2328.

This allows us to keep all the code, except users won't be able to
configure the SDK with this option.
Note that `Signing.ResponseVerificationMode.enforced` _is_ available, so
we can still test all that behavior, including from integration tests.
@RCGitBot RCGitBot mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonidero tonidero tonidero approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NachoSoto @tonidero