Skip to content

Update Gemfile.lock#2254

Merged
vegaro merged 3 commits into
mainfrom
update-danger
Feb 2, 2023
Merged

Update Gemfile.lock#2254
vegaro merged 3 commits into
mainfrom
update-danger

Conversation

@vegaro

@vegaro vegaro commented Jan 31, 2023

Copy link
Copy Markdown
Member

We got some dependabot alerts of high severity vulnerabilities https://github.com/RevenueCat/purchases-ios/security/dependabot

@vegaro vegaro added the pr:dependencies Changes on external dependencies label Jan 31, 2023
@vegaro vegaro requested a review from a team January 31, 2023 17:42
Comment thread Gemfile.lock Outdated
CFPropertyList
naturally
sqlite3 (1.4.4)
sqlite3 (1.6.0-arm64-darwin)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm this is making it fail 🤔

@vegaro vegaro Jan 31, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I changed the platforms and I think it's now fixed. I also did this so the version of macos doesn't keep changing and growing in the platforms section

bundle lock --remove-platform arm64-darwin-21
bundle lock --add-platform arm64-darwin

It was only adding the arm64 dependency before because in my machine it was removing the ruby platform too (I removed the Gemfile.lock and ran bundle install, so bundler thought the only required architecture was arm64).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm it's still failing 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the new platform for now, because it adds sqlite3 (1.6.0-arm64-darwin) which makes CircleCI fail

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I don't know why it's adding this dependency version either... so I think that makes sense

Comment thread Gemfile.lock Outdated
zeitwerk (2.6.6)

PLATFORMS
arm64-darwin

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just remove this for now, because it adds sqlite3 (1.6.0-arm64-darwin) which makes CI fail

@codecov

codecov Bot commented Jan 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2254 (3740620) into main (c765b18) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2254      +/-   ##
==========================================
+ Coverage   85.90%   85.96%   +0.05%     
==========================================
  Files         183      183              
  Lines       12125    12125              
==========================================
+ Hits        10416    10423       +7     
+ Misses       1709     1702       -7     
Impacted Files Coverage Δ
...chasing/StoreKitAbstractions/SK1StoreProduct.swift 92.30% <0.00%> (-5.77%) ⬇️
Sources/Logging/Strings/NetworkStrings.swift 100.00% <0.00%> (+1.63%) ⬆️
Sources/Networking/HTTPClient/HTTPClient.swift 98.20% <0.00%> (+3.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NachoSoto NachoSoto changed the title Update Gemfile.lock Update Gemfile.lock Feb 2, 2023
@vegaro vegaro merged commit 84a78bf into main Feb 2, 2023
@vegaro vegaro deleted the update-danger branch February 2, 2023 19:46
NachoSoto pushed a commit that referenced this pull request Feb 8, 2023
**This is an automatic release.**

### Dependency Updates
* Bump fastlane-plugin-revenuecat_internal from `738f255` to `9255366`
(#2264) via dependabot[bot] (@dependabot[bot])
* Update `Gemfile.lock` (#2254) via Cesar de la Vega (@vegaro)
### Other Changes
* `HTTPClient`: added support for sending `X-Nonce` (#2214) via
NachoSoto (@NachoSoto)
* `Configuration`: added (`internal` for now) API to load public key
(#2215) via NachoSoto (@NachoSoto)
* Replaced `Any` uses for workaround with `Box` (#2250) via NachoSoto
(@NachoSoto)
* `HTTPClientTests`: fixed failing test with missing assertions (#2262)
via NachoSoto (@NachoSoto)
* `HTTPClientTests`: refactored tests to use `waitUntil` (#2257) via
NachoSoto (@NachoSoto)
* PurchaseTester: Add Receipt Inspector UI (#2249) via Andy Boedo
(@aboedo)
* Adds dependabot (#2259) via Cesar de la Vega (@vegaro)
* `StoreKit1WrapperTests`: avoid using `Bool.random` to fix flaky code
coverage (#2258) via NachoSoto (@NachoSoto)
* `IntroEligibilityCalculator`: changed logic to handle products with no
subscription group (#2247) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:dependencies Changes on external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants