StoreKitIntegrationTests: replaced XCTSkipIf with XCTExpectFailure#2244
Merged
Conversation
See https://developer.apple.com/documentation/xctest/expected_failures I realized this going through the old PR. Better to actually run the test so that if/when it gets fixed in the future, we're notified because it will "fail".
Codecov Report
@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
- Coverage 85.85% 85.83% -0.03%
==========================================
Files 183 183
Lines 12105 12105
==========================================
- Hits 10393 10390 -3
- Misses 1712 1715 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Something's weird with these coverage diffs, I wonder if we have some randomness in some test that makes that fluctuate. |
tonidero
approved these changes
Jan 26, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Hmm yeah... Not sure about the coverage change... Code change looks ok though
tonidero
pushed a commit
that referenced
this pull request
Feb 1, 2023
**This is an automatic release.** ### Bugfixes * `CustomerInfoManager`: improved thread-safety (#2224) via NachoSoto (@NachoSoto) ### Other Changes * `StoreKitIntegrationTests`: replaced `XCTSkipIf` with `XCTExpectFailure` (#2244) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: changed `ReceiptRefreshPolicy.always` to `.onlyIfEmpty` after a purchase (#2245) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://developer.apple.com/documentation/xctest/expected_failures
I realized this going through the old PR. Better to actually run the test so that if/when it gets fixed in the future, we're notified because it will "fail".