Conversation
NachoSoto
reviewed
Dec 15, 2022
NachoSoto
left a comment
Contributor
There was a problem hiding this comment.
Nice find 👍🏻
Just a few style / refactor things.
| let product = try await fetchSk2Product() | ||
|
|
||
| _ = try await orchestrator.purchase(sk2Product: product, promotionalOffer: nil) | ||
| _ = try await orchestrator.purchase(sk2Product: product, package: nil, promotionalOffer: nil) |
Contributor
There was a problem hiding this comment.
👍🏻 Good idea testing with nil too.
NachoSoto
approved these changes
Dec 15, 2022
NachoSoto
pushed a commit
that referenced
this pull request
Dec 15, 2022
**This is an automatic release.** ### Bugfixes * Fix sending presentedOfferingIdentifier in StoreKit2 (#2156) via Toni Rico (@tonidero) * `ReceiptFetcher`: throttle receipt refreshing to avoid `StoreKit` throttle errors (#2146) via NachoSoto (@NachoSoto) ### Other Changes * Added integration and unit tests to verify observer mode behavior (#2069) via NachoSoto (@NachoSoto) * Created `ClockType` and `TestClock` to be able to mock time (#2145) via NachoSoto (@NachoSoto) * Extracted `asyncWait` to poll `async` conditions in tests (#2134) via NachoSoto (@NachoSoto) * `StoreKitRequestFetcher`: added log when starting/ending requests (#2151) via NachoSoto (@NachoSoto) * `CI`: fixed `PurchaseTester` deployment (#2147) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes CSDK-546
Looks like we were not caching the offeringIdentifier for a productIdentifier when using store kit 2. This should fix that.