Exposed `PurchasesReceiptParser` and `AppleReceipt` by NachoSoto · Pull Request #2153 · RevenueCat/purchases-ios

NachoSoto · 2022-12-14T21:08:16Z

Initial step for CSDK-17. Fixes CSDK-523.

Changes:

Renamed ReceiptParser to PurchasesReceiptParser to avoid name collision with future SPM ReceiptParser
Exposed ReceiptParser, AppleReceipt, PurchasesReceiptParser.Error
Added new types to SwiftAPITester
Added docs to these types
Moved LoggerType to be available to ReceiptParser
Moved DateFormatter+Extensions to be available to ReceiptParser
Moved Codable+Extensions to be available to ReceiptParser
Created ReceiptParserLogger for ReceiptParser

NachoSoto · 2022-12-14T21:54:37Z

Didn't do this on purpose, I created a new file with the same contents.

NachoSoto · 2022-12-14T21:54:42Z

Didn't do this on purpose, I created a new file with the same contents.

tonidero

It looks good but I will hold off approval until #2155 is also ready, to avoid adding new APIs and removing them later.

tonidero · 2022-12-21T11:16:43Z

+
+    var prettyPrintedData: Data {
+        get throws {
+            return try JSONEncoder.prettyPrinted.encode(self)


This was like this before but this assumes that all Encodable can be encoded as JSON or throw right? Not sure if that's true, but since this isn't a real change and doesn't seem to have caused issues, we can leave for now.

That is true, that’s what Codable ensures in Swift.

tonidero · 2022-12-21T12:14:55Z

        // Only checking on integration tests.
        // Unit tests might run on the main thread when testing this class directly.
-        if ProcessInfo.isRunningIntegrationTests {
+        if ProcessInfo.processInfo.environment["RCRunningIntegrationTests"] == "1" {


Don't know if there is a way in iOS to know if it's running tests generically so it's done automatically even for other people using this as a library... This should be ok for now though.

There is, but we decided to use a separate variable: #2100 (comment)

tonidero · 2022-12-21T12:23:21Z

+
+import Foundation
+
+final class ReceiptParserLogger: LoggerType {


Hmm I believe this is currently unused?

Hmm maybe, I split this PR in 2, so it’s possible this will be used by #2155

tonidero · 2022-12-21T12:30:12Z


+### Parsing Receipts
+- ``PurchasesReceiptParser``
+- ``AppleReceipt``


We are planning to move these to the SPM library later right? I'm concerned about making this part of the SDK public API here and then moving them to a library later on since that would mean it would be a breaking change unless we can somehow make it a transitive dependency... Should we hold on merging this to main until the SPM library part is also ready? (I haven't checked #2155 yet)

See my other comment, we’ll be exposing this as part of the SDK too for users who already use the main Framework.

Ahhh ok makes sense!

NachoSoto · 2022-12-21T15:36:46Z

It looks good but I will hold off approval until #2155 is also ready, to avoid adding new APIs and removing them later.

They’re not going to be removed. You’ll be able to use this either from the main Framework or using the new one only.

NachoSoto · 2022-12-21T15:40:59Z

Thanks for the review! I know this one was a big PR.

NachoSoto · 2022-12-21T16:24:05Z

I'll hold on merging this for today's hotfix so we get all those bugfixes first before creating a minor release with the new API.

Initial step for [CSDK-17]. - Renamed `ReceiptParser` to `PurchasesReceiptParser` to avoid name collision with future SPM `ReceiptParser` - Exposed `ReceiptParser`, `AppleReceipt`, `PurchasesReceiptParser.Error` - Added new types to `SwiftAPITester` - Added docs to these types - Moved `LoggerType` to be available to `ReceiptParser` - Moved `DateFormatter+Extensions` to be available to `ReceiptParser` - Moved `Codable+Extensions` to be available to `ReceiptParser` - Created `ReceiptParserLogger` for `ReceiptParser`

Finishes [CSDK-17]. Follow up to #2153. Extracted from #2096. ### Changes: - Created target in `Package.swift`. It can be built separately: `swift build --target ReceiptParser` ![Screenshot 2022-11-29 at 09 29 10](https://user-images.githubusercontent.com/685609/204600321-9c99958c-a683-4b59-8334-df1cf1235d1d.png) - Created `ReceiptParser` target in project: ![Screenshot 2022-12-14 at 13 56 38](https://user-images.githubusercontent.com/685609/207723593-40535089-1436-4b62-81cc-d098d589f83a.png) - Added `ReceiptParser` scheme to allow building the target from Xcode: ![Screenshot 2022-12-14 at 13 57 02](https://user-images.githubusercontent.com/685609/207723665-dace0aa1-4ae7-4382-895f-908f356043b4.png) - Added CI `spm-receipt-parser` job - Added CI `installation-tests-receipt-parser` job - Added `ReceiptParserAPITester` to test API for `ReceiptParser`'s target - Compile `ReceiptParserAPITester` when running `RevenueCat` tests so these are validated as well. - [CSDK-17]: https://revenuecats.atlassian.net/browse/CSDK-17?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

@NachoSoto

**This is an automatic release.** ### New Features * Created `ReceiptParser` SPM (#2155) via NachoSoto (@NachoSoto) * Exposed `PurchasesReceiptParser` and `AppleReceipt` (#2153) via NachoSoto (@NachoSoto) ### Bugfixes * `Restore purchases`: post product data when posting receipts (#2178) via NachoSoto (@NachoSoto) ### Other Changes * Added `Dictionary.merge` (#2190) via NachoSoto (@NachoSoto) * `CircleCI`: use Xcode 14.2.0 (#2187) via NachoSoto (@NachoSoto) * `ReceiptParser`: a few documentation improvements (#2189) via NachoSoto (@NachoSoto) * `Purchase Tester`: fixed `TestFlight` deployment (#2188) via NachoSoto (@NachoSoto) * `Purchase Tester`: display specific `IntroEligibilityStatus` (#2184) via NachoSoto (@NachoSoto) * `Purchase Tester`: fixed `SubscriptionPeriod` (#2185) via NachoSoto (@NachoSoto)

NachoSoto added the pr:feat A new feature label Dec 14, 2022

NachoSoto requested a review from a team December 14, 2022 21:08

This was referenced Dec 14, 2022

Created ReceiptParser SPM #2155

Merged

[WIP] Separate ReceiptParser SPM Package #2096

Closed

NachoSoto force-pushed the receipt-parser-public branch 3 times, most recently from a9ae4cd to d356639 Compare December 14, 2022 21:46

NachoSoto commented Dec 14, 2022

View reviewed changes

NachoSoto force-pushed the receipt-parser-public branch 2 times, most recently from 0ff0269 to 1b9e77a Compare December 20, 2022 18:08

tonidero reviewed Dec 21, 2022

View reviewed changes

tonidero approved these changes Dec 21, 2022

View reviewed changes

NachoSoto force-pushed the receipt-parser-public branch from 1b9e77a to 05d4883 Compare December 22, 2022 17:59

NachoSoto enabled auto-merge (squash) December 22, 2022 18:00

NachoSoto merged commit b3875a9 into main Dec 22, 2022

NachoSoto deleted the receipt-parser-public branch December 22, 2022 18:09

RCGitBot mentioned this pull request Dec 27, 2022

[AUTOMATIC] Release/4.16.0 #2191

Merged


		import Foundation

		final class ReceiptParserLogger: LoggerType {

Conversation

NachoSoto commented Dec 14, 2022 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Dec 21, 2022

Uh oh!

NachoSoto commented Dec 21, 2022

Uh oh!

NachoSoto commented Dec 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NachoSoto commented Dec 14, 2022 •

edited by atlassian Bot

Loading