ReceiptParser: ensure parsing never happens in the main thread#2123
Merged
Conversation
89a2ce8 to
5ccd6ef
Compare
This was referenced Dec 9, 2022
tonidero
approved these changes
Dec 13, 2022
NachoSoto
pushed a commit
that referenced
this pull request
Dec 14, 2022
**This is an automatic release.** ### Bugfixes * Un-deprecate `Purchases.configure(withAPIKey:appUserID:)` and `Purchases.configure(withAPIKey:appUserID:observerMode:)` (#2129) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptFetcherTests`: refactored tests using `waitUntilValue` (#2144) via NachoSoto (@NachoSoto) * Added a few performance improvements for `ReceiptParser` (#2124) via NachoSoto (@NachoSoto) * `CallbackCache`: fixed reference (#2143) via NachoSoto (@NachoSoto) * `PostReceiptDataOperation`: clarified receipt debug log (#2128) via NachoSoto (@NachoSoto) * `CallbackCache`: avoid exposing internal mutable cache (#2136) via NachoSoto (@NachoSoto) * `CallbackCache`: added assertion for tests to ensure we don't leak callbacks (#2137) via NachoSoto (@NachoSoto) * `NetworkOperation`: made `Atomic` references immutable (#2139) via NachoSoto (@NachoSoto) * `ReceiptParser`: ensure parsing never happens in the main thread (#2123) via NachoSoto (@NachoSoto) * `PostReceiptDataOperation`: also print receipt data with `verbose` logs (#2127) via NachoSoto (@NachoSoto) * `BasePurchasesTests`: detecting and fixing many `DeviceCache` leaks (#2105) via NachoSoto (@NachoSoto) * `StoreKitIntegrationTests`: added test to check applying a promotional offer during subscription (#1588) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
that referenced
this pull request
Jul 31, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Jul 31, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 3, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 7, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 14, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 17, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 24, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 28, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Aug 31, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 1, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 6, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 6, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 6, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 7, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 8, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 14, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 14, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
NachoSoto
added a commit
that referenced
this pull request
Sep 15, 2023
Follow-up to #2860. Thanks to integration tests for catching this (#2123). 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2107 and SDKONCALL-180.
This comment pointed out that parsing a long receipt can freeze the UI for almost a second.