Added LogLevel.verbose#2080
Conversation
vegaro
left a comment
There was a problem hiding this comment.
This is breaking our public API correct?
|
By breaking do you mean because we added a new Well I suppose users implementing their own |
|
@NachoSoto this does technically fall under feat since it's a new enum case. |
|
Oh yeah that's a great point!! |
I want to add some extra logs to figure out [CSDK-517] which would be too verbose (no pun intended) for `debug`, so this will allow us to have some additional logging that wouldn't be enabled by default.
60b8925 to
46562ec
Compare
|
Changed to stable IDs and made this |
Depends on #2080. This will help debug [CSDK-517]. ### Examples: ``` - VERBOSE: Purchases.init: created new Purchases instance: Purchases (0x00006000037af800) StoreKit Wrapper: left(<RevenueCat.StoreKit1Wrapper: 0x600000b6d3a0>) - VERBOSE: Purchases.deinit: Purchases (0x0000600003f82600) ```
…2082) Depends on #2080. This will help debug [CSDK-517]. ### Examples: ``` - VERBOSE: Purchases.init: created new Purchases instance: Purchases (0x00006000037af800) StoreKit Wrapper: left(<RevenueCat.StoreKit1Wrapper: 0x600000b6d3a0>) - VERBOSE: Purchases.deinit: Purchases (0x0000600003f82600) ``` [CSDK-517]: https://revenuecats.atlassian.net/browse/CSDK-517?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
|
Thanks for explaining @aboedo , that's exactly what I meant. I should've been more clear about my concern :) |
A last minute change in #2080 made `LogLevel.verbose` have a higher `rawValue` to maintain backwards compatibility. Unfortunately, we we re relying on these to implement ordering. This PR makes that explicit by making `LogLevel` conform to `Comparable`, and added tests to verify this behavior in `Logger`.
I want to add some extra logs to figure out CSDK-517 which would be too verbose (no pun intended) for
debug, so this will allow us to have some additional logging that wouldn't be enabled by default.