SKTestSession: finish all unfinished transactions before starting each test#2066
Merged
Conversation
NachoSoto
commented
Nov 17, 2022
Contributor
Author
There was a problem hiding this comment.
I moved this from StoreKitTestHelpers.swift into this file since this is only for StoreKitConfigTestCase and not relevant for integration tests.
6039819 to
7ef2d91
Compare
Contributor
Author
SKTestSession: finish all unfinished transactions when beginning testsSKTestSession: finish all unfinished transactions before beginning tests
SKTestSession: finish all unfinished transactions before beginning testsSKTestSession: finish all unfinished transactions before starting each test
Contributor
Author
|
Actually, I wonder if this will make that issue better (see https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/8929/workflows/e990dfcf-effb-4923-b688-1e3655aee62a/jobs/44610). |
aboedo
approved these changes
Nov 24, 2022
Filed this as `FB11799675`. I noticed some tests began with prior transactions (despite using `SKTestSession.clearTransactions`), so this workaround ensures each test begins in a clean state.
d5a10c5 to
af643ba
Compare
NachoSoto
added a commit
that referenced
this pull request
Nov 28, 2022
I wrote all these to cover the change in #2063. I wrote a failing test that only passed with the change in #2063. However, when running that in SK1, that would fail. With the change as suggested in #2063, the SK2 behavior would differ from SK1. From the `Transaction.all` docs: > This sequence returns the user’s transaction history current to the moment you access the sequence. The sequence emits a finite number of transactions. If the App Store processes new transactions for the user while you’re accessing this sequence, the new transactions appear in the transaction listener, updates. So all these new tests verify the behavior of the SDK when encountering transactions created prior to initializing the SDK. Depends on #2064 and #2066.
NachoSoto
added a commit
that referenced
this pull request
Dec 15, 2022
I wrote all these to cover the change in #2063. I wrote a failing test that only passed with the change in #2063. However, when running that in SK1, that would fail. With the change as suggested in #2063, the SK2 behavior would differ from SK1. From the `Transaction.all` docs: > This sequence returns the user’s transaction history current to the moment you access the sequence. The sequence emits a finite number of transactions. If the App Store processes new transactions for the user while you’re accessing this sequence, the new transactions appear in the transaction listener, updates. So all these new tests verify the behavior of the SDK when encountering transactions created prior to initializing the SDK. Depends on #2064 and #2066.
NachoSoto
added a commit
that referenced
this pull request
Dec 15, 2022
) See [TRIAGE-179]. I wrote all these to cover the change in #2063. I wrote a failing test that only passed with the change in #2063. However, when running that in SK1, that would fail. With the change as suggested in #2063, the SK2 behavior would differ from SK1. From the `Transaction.all` docs: > This sequence returns the user’s transaction history current to the moment you access the sequence. The sequence emits a finite number of transactions. If the App Store processes new transactions for the user while you’re accessing this sequence, the new transactions appear in the transaction listener, updates. These new tests verify the behavior of the SDK when encountering transactions created prior to initializing the SDK, and some made after initialization. Integration tests now are as follows: - `BaseStoreKitIntegrationTests` - `StoreKit1IntegrationTests` - `StoreKit2IntegrationTests` - `BaseStoreKitObserverModeIntegrationTests`: - `StoreKit1ObserverModeIntegrationTests` - `StoreKit2ObserverModeIntegrationTests` - `StoreKit1ObserverModeWithExistingPurchasesTests` - `StoreKit2ObserverModeWithExistingPurchasesTests` Depends on #2064, #2066, and #2134. [TRIAGE-179]: https://revenuecats.atlassian.net/browse/TRIAGE-179?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
5 tasks
NachoSoto
added a commit
that referenced
this pull request
Dec 20, 2022
See #2066. I saw a bunch of these messages: > DEBUG: ℹ️ Finishing 0 transactions before running tests Which doesn't add anything if there aren't any leftover transactions.
NachoSoto
added a commit
that referenced
this pull request
Dec 20, 2022
See #2066. I saw a bunch of these messages: > DEBUG: ℹ️ Finishing 0 transactions before running tests Which doesn't add anything if there aren't any leftover transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filed this as
FB11799675. I noticed some tests began with prior transactions (despite usingSKTestSession.clearTransactions), so this workaround ensures each test begins in a clean state.