Integration Tests: fixed testPurchaseWithAskToBuyPostsReceipt#2040
Merged
Conversation
This was failing with `StoreKit 2` (probably a recent `SKTestSession`/`StoreKit` change since it used to pass):
```
[00:51:46]: ▸ 2022-11-09 00:51:46.820614+0000 BackendIntegrationTestsHostApp[4240:21475] [Default] [StoreKit] Received error that does not have a corresponding StoreKit Error:
[00:51:46]: ▸ Error Domain=ASDServerErrorDomain Code=3532 "You’re currently subscribed to this." UserInfo={storefront-country-code=USA, client-environment-type=XcodeTest(/Users/distiller/Library/Developer/CoreSimulator/Devices/E616C409-03A4-4A07-B2DC-FFF7544CBCCD/data/Containers/Shared/App ... tTestApp), AMSServerErrorCode=3532, NSLocalizedDescription=You’re currently subscribed to this.}
[00:51:46]: ▸ 2022-11-09 00:51:46.820780+0000 BackendIntegrationTestsHostApp[4240:21475] [Default] [StoreKit] Purchase did not return a transaction: Error Domain=ASDServerErrorDomain Code=3532 "You’re currently subscribed to this." UserInfo={storefront-country-code=USA, client-environment-type=XcodeTest(/Users/distiller/Library/Developer/CoreSimulator/Devices/E616C409-03A4-4A07-B2DC-FFF7544CBCCD/data/Containers/Shared/App ... tTestApp), AMSServerErrorCode=3532, NSLocalizedDescription=You’re currently subscribed to this.}
[00:51:46]: ▸ 2022-11-09 00:51:46.821036+0000 BackendIntegrationTestsHostApp[4240:21475] [Purchases] - ERROR: 🍎‼️ There was a problem with the App Store.
[00:51:46]: ▸ 2022-11-09 00:51:46.821236+0000 BackendIntegrationTestsHostApp[4240:21475] [Purchases] - ERROR: 💰 Product purchase for 'com.revenuecat.monthly_4.99.1_week_intro' failed with error: PurchasesError(error: There was a problem with the App Store., userInfo: ["readable_error_code": "STORE_PROBLEM", "NSLocalizedDescription": "There was a problem with the App Store.", "source_file": "RevenueCat/StoreKitError+Extensions.swift:43", "source_function": "asPurchasesError", "NSUnderlyingError": StoreKit.StoreKitError.unknown])
[00:51:46]: ▸ <unknown>:0: error: -[BackendIntegrationTests.StoreKit2IntegrationTests testPurchaseWithAskToBuyPostsReceipt] : failed: caught error: "There was a problem with the App Store."
[00:51:46]: ▸ Test Case '-[BackendIntegrationTests.StoreKit2IntegrationTests testPurchaseWithAskToBuyPostsReceipt]' failed (0.827 seconds).
```
With this change, instead of trying to purchase it again, we simply restore purchases to confirm that the purchase went through after approving it.
vegaro
approved these changes
Nov 9, 2022
277e074 to
f36d99c
Compare
NachoSoto
pushed a commit
that referenced
this pull request
Nov 9, 2022
**This is an automatic release.** ### Bugfixes * `ISO8601DateFormatter.withMilliseconds`: fixed iOS 11 crash (#2037) via NachoSoto (@NachoSoto) * Changed `StoreKit2Setting.default` back to `.enabledOnlyForOptimizations` (#2022) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: changed weekly to monthly subscriptions to work around 0-second subscriptions (#2042) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed `testPurchaseWithAskToBuyPostsReceipt` (#2040) via NachoSoto (@NachoSoto) * `ReceiptRefreshPolicy.retryUntilProductIsFound`: default to returning "invalid" receipt (#2024) via NachoSoto (@NachoSoto) * `CachingProductsManager`: use partial cached products (#2014) via NachoSoto (@NachoSoto) * Added `BackendErrorCode.purchasedProductMissingInAppleReceipt` (#2033) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: replaced `Purchases` dependency with `SPM` (#2027) via NachoSoto (@NachoSoto) * `Integration Tests`: changed log output to `raw` (#2031) via NachoSoto (@NachoSoto) * `Integration Tests`: run on iOS 16 (#2035) via NachoSoto (@NachoSoto) * CI: fixed `iOS 14` tests Xcode version (#2030) via NachoSoto (@NachoSoto) * `Async.call`: added non-throwing overload (#2006) via NachoSoto (@NachoSoto) * Documentation: Fixed references in `V4_API_Migration_guide.md` (#2018) via NachoSoto (@NachoSoto) * `eligiblePromotionalOffers`: don't log error if response is ineligible (#2019) via NachoSoto (@NachoSoto) * Runs push-pods after make-release (#2025) via Cesar de la Vega (@vegaro) * Some updates on notify-on-non-patch-release-branches: (#2026) via Cesar de la Vega (@vegaro) * Deploy `PurchaseTesterSwiftUI` to TestFlight (#2003) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added "logs" screen (#2012) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: allow configuring API key at runtime (#1999) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/8800/workflows/15003c88-3322-4c55-8cc4-e44d4494b9c3/jobs/43446/tests
This was failing with
StoreKit 2(probably a recentSKTestSession/StoreKitchange since it used to pass):With this change, instead of trying to purchase it again, we simply restore purchases to confirm that the purchase went through after approving it.