Integration Tests: changed weekly to monthly subscriptions to work around 0-second subscriptions#2039
Merged
Conversation
…around 0-second subscriptions As exposed by #2038, weekly subscriptions were leading to false negatives because they were always expired by the time the purchase was made using `TimeRate.monthlyRenewalEveryThirtySeconds`, instead of lasting 10 seconds as documented. (`FB11767559`) The advantage of using weekly subscriptions was to also work around `FB11767679`, which means that we have to manually _wait_ for the subscription to expire, as `SKTestSession.expireSubscription(productIdentifier:)` doesn't actually change the receipt. Because we had to wait, using weekly subscriptions was faster, since we only needed to wait 10 seconds. This does mean that expirations in these tests now have to wait 30 seconds instead of 10, but now they're no longer flaky 🎉
f99328a to
021fed0
Compare
vegaro
approved these changes
Nov 9, 2022
aboedo
approved these changes
Nov 9, 2022
aboedo
left a comment
Member
There was a problem hiding this comment.
Looks like tests right now pass in CI in less than 7 minutes, which I believe it totally acceptable, especially for the benefit of no longer having these flaky tests.
💯
Contributor
Author
|
Oops I merged this into the other branch, let me re-open the PR.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As exposed by #2038, weekly subscriptions were leading to false negatives because they were always expired by the time the purchase was made (using
TimeRate.monthlyRenewalEveryThirtySeconds), instead of lasting 10 seconds as documented. This is reported asFB11767559.The advantage of using weekly subscriptions was to also work around
FB11767679, which means that we have to manually wait for the subscription to expire, asSKTestSession.expireSubscription(productIdentifier:)doesn't actually change the receipt.Because we had to wait, using weekly subscriptions was faster, since we only needed to wait 10 seconds.
This does mean that expirations in these tests now have to wait 30 seconds instead of 10, but now they're no longer flaky 🎉
Looks like tests right now pass in CI in less than 7 minutes, which I believe is totally acceptable, especially for the benefit of no longer having these flaky tests.