PaymentQueueWrapper: also conform to SKPaymentTransactionObserver to fix promoted purchases#1962
Merged
Merged
Conversation
4eedf0d to
688b5cf
Compare
NachoSoto
commented
Sep 30, 2022
Contributor
Author
There was a problem hiding this comment.
This is equivalent, but avoids duplicating the expectation in the if and the assert.
9d67a6c to
8e43fe8
Compare
vegaro
approved these changes
Oct 5, 2022
|
|
||
| extension PaymentQueueWrapper: SKPaymentQueueDelegate { | ||
|
|
||
| } |
Contributor
Author
There was a problem hiding this comment.
Ugh I did this a week ago and now I'm confusing myself. My best guess is I forgot something, one sec.
Contributor
Author
There was a problem hiding this comment.
I was in the process of implementing this protocol too, when I was convinced I already did it...
Yup, that's in #1963 🤦🏻♂️
8e43fe8 to
3ef87d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1901. That fix was incomplete. I missed it because the protocols were mixed up (fixed in #1961). Now
PaymentQueueWrapper, when set up as the delegate (only when SK2 is enabled and SK1 is disabled) will be added as a transaction observer.