Moved InAppPurchase into AppleReceipt#1942
Merged
Merged
Conversation
The name `InAppPurchase` is too general. This type in particular is specific to the content of `AppleReceipt`, so nesting it makes that clear. Follow up to #1933.
91d6276 to
12b9cd9
Compare
NachoSoto
pushed a commit
that referenced
this pull request
Sep 28, 2022
**This is an automatic release.** ### Other Changes * `ProductsFetcherSK2`: removed now redundant caching logic (#1908) via NachoSoto (@NachoSoto) * Created `CachingProductsManager` to provide consistent caching logic when fetching products (#1907) via NachoSoto (@NachoSoto) * Refactored `ReceiptFetcher.receiptData` (#1941) via NachoSoto (@NachoSoto) * Abstracted conversion from `async` to completion-block APIs (#1943) via NachoSoto (@NachoSoto) * Moved `InAppPurchase` into `AppleReceipt` (#1942) via NachoSoto (@NachoSoto) * `Purchases+async`: combined `@available` statements into a single one (#1944) via NachoSoto (@NachoSoto) * `Integration Tests`: don't initialize `Purchases` until the `SKTestSession` has been re-created (#1946) via NachoSoto (@NachoSoto) * `PostReceiptDataOperation`: print receipt data if `debug` logs are enabled (#1940) via NachoSoto (@NachoSoto) Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>
NachoSoto
added a commit
that referenced
this pull request
Oct 7, 2022
Fixes [CSDK-478] ~~Depends on #1941, #1942, and #1943.~~ ### Example: Log of a successful purchase after retrying 🎉 > INFO: 💰 Purchasing Product 'com.revenuecat.monthly_4.99.1_week_intro' DEBUG: ℹ️ Loaded receipt from url file:///Users/nachosoto/Library/Developer/CoreSimulator/Devices/A3576DC2-355E-45BA-B32C-D2C0A3811BB4/data/Containers/Data/Application/7ACD12DA-2A12-4CF1-8A76-8295E40B64EF/StoreKit/receipt INFO: ℹ️ Receipt parsed successfully WARN: 🍎‼️ Local receipt is still missing purchase for 'com.revenuecat.monthly_4.99.1_week_intro': { "opaque_value" : "79v2XwwAAAA=", "sha1_hash" : "GhOmfuioo2Z4R3zX8K60l4b0qgs=", "bundle_id" : "com.revenuecat.StoreKitTestApp", "in_app_purchases" : [ { "quantity" : 1, "product_id" : "com.revenuecat.monthly_4.99.1_week_intro", "purchase_date" : "2022-09-28T01:14:24Z", "transaction_id" : "0", "is_in_intro_offer_period" : true, "expires_date" : "2022-09-28T01:14:34Z" } ], "application_version" : "1", "creation_date" : "2022-09-28T01:14:24Z", "expiration_date" : "4001-01-01T00:00:00Z" } DEBUG: ℹ️ Retrying Receipt fetch after 5 seconds DEBUG: ℹ️ API request completed: POST /v1/receipts 200 DEBUG: ℹ️ PostReceiptDataOperation: Finished DEBUG: ℹ️ Serial request done: POST receipts, 0 requests left in the queue DEBUG: ℹ️ Sending updated CustomerInfo to delegate. DEBUG: ℹ️ Found 0 unsynced attributes for App User ID: $RCAnonymousID:ec326c1613c14b489980eace90dceabb DEBUG: ℹ️ Force refreshing the receipt to get latest transactions from Apple. DEBUG: ℹ️ Loaded receipt from url file:///Users/nachosoto/Library/Developer/CoreSimulator/Devices/A3576DC2-355E-45BA-B32C-D2C0A3811BB4/data/Containers/Data/Application/7ACD12DA-2A12-4CF1-8A76-8295E40B64EF/StoreKit/receipt DEBUG: ℹ️ PostReceiptDataOperation: Started INFO: ℹ️ Receipt parsed successfully DEBUG: ℹ️ PostReceiptDataOperation: Posting receipt: { "opaque_value" : "0nf1uwEAAAA=", "sha1_hash" : "lfxVVsBuSkQLtrGJseZ8zlpXc5A=", "bundle_id" : "com.revenuecat.StoreKitTestApp", "in_app_purchases" : [ { "quantity" : 1, "product_id" : "com.revenuecat.monthly_4.99.1_week_intro", "purchase_date" : "2022-09-28T01:14:24Z", "transaction_id" : "0", "is_in_intro_offer_period" : true, "expires_date" : "2022-09-28T01:14:34Z" }, { "product_id" : "com.revenuecat.monthly_4.99.1_week_intro", "quantity" : 1, "transaction_id" : "1", "is_in_intro_offer_period" : false, "expires_date" : "2022-09-28T01:15:04Z", "original_purchase_date" : "2022-09-28T01:14:24Z", "original_transaction_id" : "0", "purchase_date" : "2022-09-28T01:14:34Z" } ], "application_version" : "1", "creation_date" : "2022-09-28T01:14:35Z", "expiration_date" : "4001-01-01T00:00:00Z" } DEBUG: ℹ️ There are no requests currently running, starting request POST receipts DEBUG: ℹ️ API request started: POST /v1/receipts DEBUG: ℹ️ API request completed: POST /v1/receipts 200 DEBUG: ℹ️ PostReceiptDataOperation: Finished DEBUG: ℹ️ Serial request done: POST receipts, 0 requests left in the queue DEBUG: ℹ️ Sending updated CustomerInfo to delegate. DEBUG: ℹ️ Loaded receipt from url file:///Users/nachosoto/Library/Developer/CoreSimulator/Devices/A3576DC2-355E-45BA-B32C-D2C0A3811BB4/data/Containers/Data/Application/7ACD12DA-2A12-4CF1-8A76-8295E40B64EF/StoreKit/receipt INFO: ℹ️ Receipt parsed successfully DEBUG: ℹ️ Skipping products request because products were already cached. products: ["com.revenuecat.monthly_4.99.1_week_intro"] DEBUG: ℹ️ Skipping products request because products were already cached. products: ["com.revenuecat.monthly_4.99.1_week_intro"] DEBUG: ℹ️ Store products request finished DEBUG: ℹ️ Found 0 unsynced attributes for App User ID: $RCAnonymousID:ec326c1613c14b489980eace90dceabb DEBUG: ℹ️ PostReceiptDataOperation: Started INFO: ℹ️ Receipt parsed successfully DEBUG: ℹ️ PostReceiptDataOperation: Posting receipt: { "opaque_value" : "tv4\/2gcAAAA=", "sha1_hash" : "0rh1naTc3JyfM16M\/1f6fw4ezAY=", "bundle_id" : "com.revenuecat.StoreKitTestApp", "in_app_purchases" : [ { "quantity" : 1, "product_id" : "com.revenuecat.monthly_4.99.1_week_intro", "purchase_date" : "2022-09-28T01:14:24Z", "transaction_id" : "0", "is_in_intro_offer_period" : true, "expires_date" : "2022-09-28T01:14:34Z" }, { "product_id" : "com.revenuecat.monthly_4.99.1_week_intro", "quantity" : 1, "transaction_id" : "1", "is_in_intro_offer_period" : false, "expires_date" : "2022-09-28T01:15:04Z", "original_purchase_date" : "2022-09-28T01:14:24Z", "original_transaction_id" : "0", "purchase_date" : "2022-09-28T01:14:34Z" } ], "application_version" : "1", "creation_date" : "2022-09-28T01:14:40Z", "expiration_date" : "4001-01-01T00:00:00Z" } DEBUG: ℹ️ There are no requests currently running, starting request POST receipts DEBUG: ℹ️ API request started: POST /v1/receipts DEBUG: ℹ️ API request completed: POST /v1/receipts 200 DEBUG: ℹ️ PostReceiptDataOperation: Finished DEBUG: ℹ️ Serial request done: POST receipts, 0 requests left in the queue INFO: 😻💰 Purchased product - 'com.revenuecat.monthly_4.99.1_week_intro' [CSDK-478]: https://revenuecats.atlassian.net/browse/CSDK-478?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name
InAppPurchaseis too general. This type in particular is specific to the content ofAppleReceipt, so nesting it makes that clear.Follow up to #1933.