Add iAd code back#1739
Merged
Merged
Conversation
added 16 commits
June 23, 2022 16:32
…migration to [AttrNetwork: String]
…tionary migration to [AttrNetwork: String]" This reverts commit d0c576f.
…il i figure out a workaround for calling deprecated stuff
NachoSoto
reviewed
Jun 27, 2022
| @available(iOS 14, *) | ||
| class IOSAttributionPosterTests: BaseAttributionPosterTests { | ||
| func testPostAppleSearchAdsAttributionIfNeededPostsIfATTFrameworkNotIncludedOnOldOS() throws { | ||
| guard #available(iOS 14, *) else { throw XCTSkip() } |
Contributor
There was a problem hiding this comment.
I think you'll still need this for tvOS (the classes get ran despite the @available annotation.
You can put this guard now in setUpWithError though.
NachoSoto
reviewed
Jun 27, 2022
| SKIP_INSTALL = YES; | ||
| SUPPORTED_PLATFORMS = "macosx iphonesimulator iphoneos watchsimulator watchos appletvsimulator appletvos"; | ||
| SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; | ||
| SWIFT_TREAT_WARNINGS_AS_ERRORS = NO; |
Contributor
There was a problem hiding this comment.
💡 I know you did this temporarily, just leaving a note here so we remember to revert it
…hases-ios into ad-services-sdk-with-iad # Conflicts: # Tests/UnitTests/Attribution/AttributionPosterTests.swift
added 2 commits
June 27, 2022 17:24
4bed32f to
bf47a65
Compare
joshdholtz
added a commit
that referenced
this pull request
Aug 8, 2022
* [CF-106] Fetch AdServices Token (#1519) Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com> Co-authored-by: Josh Holtz <me@joshholtz.com> * [CF-553] Post AdServices token (#1534) Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com> Co-authored-by: Josh Holtz <me@joshholtz.com> * Update ios 14 snapshots tets * Reworked adservices to use new Purchases.shared.attribution API * Updated with some comments from PR * Add iAd code back (#1739) Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com> * use new mapKeys dictionary extension for device cache * update for some pr comments * remove purchasestests * generate missing snapshots * fix deprecation messages to clarify method now called on shared instance * Fix for inserting nonstring into userdefaults * Add tests for bug * fix lint * Added availablility checks for tests and removed unused varialbes * Whoops... wrong class Co-authored-by: beylmk <maddie@revenuecat.com> Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per conversation here, we need to add the iAd code back since we aren't yet obsoleting it.