Separate paywalls into a different package by tonidero · Pull Request #919 · RevenueCat/purchases-flutter

tonidero · 2024-01-03T13:42:39Z

Creates purchases_flutter_ui flutter package in a folder with the functionality to presentPaywall/presentPaywallIfNeeded and removes it from the main sdk purchases_flutter.

This allows to keep the min sdk version of the main sdk lower, while still requiring a higher minSdk version for the new library.

tonidero · 2024-01-03T13:44:16Z

+  # Remove purchases_flutter_ui so it's not included in the release of the main SDK
+  # Can't use .pubignore because it causes files to not be found when trying to
+  # deploy purchases_flutter_ui
+  sh('rm', '-rf', 'purchases_flutter_ui')


This is not ideal... But didn't want to modify the whole repo architecture right now. We can revisit later.

tonidero · 2024-01-03T13:44:27Z

  Dir.chdir('..') do
    sh('flutter', 'pub', 'publish', '--dry-run')
  end
-    github_release(version: current_version_number)


Separated this into its own job

tonidero · 2024-01-03T13:45:00Z

+Dangerfile
+Gemfile
+Gemfile.lock
+pubspec.lock


We were including a bunch of things on the published package that weren't needed... This file removes most of them.

tonidero · 2024-01-03T13:46:09Z

@@ -0,0 +1 @@
+../CHANGELOG.md


I'm reusing the top-level changelog.

tonidero

This is working locally for me now and passes the publish dry run. Next would be to actually publish the library.

tonidero · 2024-01-03T15:05:50Z

+environment:
+  # TODO: Check constraints are ok
+  sdk: '>=3.2.3 <4.0.0'
+  flutter: '>=3.3.0'


These were the defaults when creating a new plugin. I think it's ok to keep them, but lmk if you think otherwise

tonidero · 2024-01-03T15:06:37Z

 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 import 'package:purchases_flutter/purchases_flutter.dart';
+import 'package:purchases_flutter_ui/purchases_flutter_ui.dart';


This is the new import, but the class is called RevenueCatUI. I thought it was ok, but lmk if you would prefer to rename the package as well.

tonidero · 2024-01-03T15:08:35Z

+
+import 'package:flutter/services.dart';
+
+class RevenueCatUI {


I modified the generated code from the wizard to resemble more closely what we do in the existing plugin. The generated code changed things so everything wasn't all static methods and better supported different communication systems with the platform (other than methodchannel). But it felt more complex so I simplified it like this.

tonidero · 2024-01-03T15:09:46Z

+
+    private lateinit var channel : MethodChannel
+
+    override fun onAttachedToEngine(flutterPluginBinding: FlutterPlugin.FlutterPluginBinding) {


In the existing plugin we also have the registerWith static method. That seems to be used for very old flutter versions, but we are not supporting those so I think it's ok to just have this.

tonidero · 2024-01-03T15:10:45Z

+# Examples
+Our examples are located at [revenuecat_examples](https://github.com/RevenueCat/purchases-flutter/tree/main/revenuecat_examples).
+
+### [Purchase Tester](https://github.com/RevenueCat/purchases-flutter/tree/main/revenuecat_examples/purchase_tester)


I didn't add MagicWeather here since it's not using paywalls at the moment.

tonidero · 2024-01-03T15:37:00Z

Note that I'm not reverting the minSdkVersion changes in the paywalls branch on the api-tester and purchase-tester apps, since those are still using the new library which does require the higher minSdk version.

vegaro · 2024-01-03T16:05:19Z

+Dangerfile
+Gemfile
+Gemfile.lock
+pubspec.lock


vegaro · 2024-01-03T16:18:18Z

+    }
+
+    private fun presentPaywall(result: Result, requiredEntitlementIdentifier: String?) {
+        val activity = getActivityFragment()


Is this an activity or a fragment? Because the function is presentPaywallFromFragment(activity,

Yeah, that function name could be confusing... This is an activity. Basically, we are presenting the paywall from the PaywallFragment, but we need the activity as a parameter to present the PaywallFragment.

This renames the `purchases_flutter_ui` package added in #919 to `purchases_ui_flutter`

@tonidero

### New features * 📱 Initial support for cross-platform RevenueCat Paywalls 🐾 🧱 (#852) #### Instructions: - For Android, you need to change your `MainActivity` to subclass `FlutterFragmentActivity` instead of `FlutterActivity`. Also, the min sdk version of the new package is `24`. Please make sure your app's `android/build.gradle` minSdkVersion has that or a higher version. - Add `purchases-ui-flutter` in your `pubspec.yaml`: ```yaml dependencies: purchases_ui_flutter: 6.15.0-beta.4 ``` #### Usage: ```dart import 'package:purchases_ui_flutter/purchases_ui_flutter.dart'; await RevenueCatUI.presentPaywallIfNeeded("pro"); ``` #### Limitations: - Currently only full screen paywalls are supported - There is no way to detect paywall events other than using `addCustomerInfoUpdateListener` #### Breaking changes from previous beta: - Paywalls functionality has been extracted into a new dependency called purchases_ui_flutter. Add purchases_ui_flutter to your pubspec.yaml. Before this release, it was part of the main RevenueCat SDK `purchases_flutter`. - A new import is required to use this functionality: `import 'package:purchases_ui_flutter/purchases_ui_flutter.dart';` - Usage has changed the class from `Purchases.presentPaywall` to `RevenueCatUI.presentPaywall`. - `presentPaywall` and `presentPaywallIfNeeded` now don't return a result. To detect purchases, please use `Purchases.getCustomerInfo` from the `purchases_flutter` SDK. A return value will be added in future releases. ### Other Changes * Fix pub score for `purchases-ui-flutter` (#924) via Toni Rico (@tonidero) * Update `paywalls` to latest `main` (#923) via Toni Rico (@tonidero) * Rename `purchases_flutter_ui` to `purchases_ui_flutter` (#921) via Toni Rico (@tonidero) * Separate paywalls into a different package (#919) via Toni Rico (@tonidero) * Remove result from presentPaywall methods (#916) via Toni Rico (@tonidero) * Update to use PHC PaywallHelpers instead of custom activity (#903) via Toni Rico (@tonidero)

tonidero added 10 commits January 2, 2024 19:06

Created new purchases_flutter_ui flutter plugin

aaaa3f5

Remove example

15e0790

Add code to support presentPaywll methods

a1ee9f7

Update purchase tester to support new library

d45d245

remove paywalls code from the main sdk

b6e46a4

Fix tests after removing present paywalls from main sdk

3b82b96

Fix pub publish issues

bb4d4dd

Fix api tests

ae4c136

Add CI and fastlane changes to support separate project

301e87f

Separate deploying new package into different job

ab29e98

tonidero added the pr:RevenueCatUI label Jan 3, 2024

tonidero changed the title ~~Separate paywalls module~~ Create purchases_flutter_ui package Jan 3, 2024

tonidero added 4 commits January 3, 2024 14:57

Fix macos compilation

f181d79

Fix podspec data

26343ca

Another macos fix

af019bb

Lower compile sdk version to 33 temporarily

ee1098f

tonidero commented Jan 3, 2024

View reviewed changes

Anodther macos fix

042e8a7

tonidero force-pushed the separate-paywalls-module branch from d0a1152 to 042e8a7 Compare January 3, 2024 14:56

tonidero commented Jan 3, 2024

View reviewed changes

tonidero marked this pull request as ready for review January 3, 2024 15:11

tonidero requested a review from a team January 3, 2024 15:11

vegaro approved these changes Jan 3, 2024

View reviewed changes

tonidero added 3 commits January 3, 2024 17:28

Fixes from review

de725d9

Update README.md for new package

3405f8b

Fix linter

f031f5c

tonidero requested a review from vegaro January 3, 2024 16:44

vegaro approved these changes Jan 3, 2024

View reviewed changes

tonidero merged commit ede6a5d into paywalls Jan 4, 2024

tonidero deleted the separate-paywalls-module branch January 4, 2024 08:03

tonidero changed the title ~~Create purchases_flutter_ui package~~ Separate paywalls into a different package Jan 4, 2024

tonidero mentioned this pull request Jan 4, 2024

Rename purchases_flutter_ui to purchases_ui_flutter #921

Merged

tonidero added a commit that referenced this pull request Jan 4, 2024

Rename purchases_flutter_ui to purchases_ui_flutter (#921)

1a1528c

This renames the `purchases_flutter_ui` package added in #919 to `purchases_ui_flutter`

tonidero mentioned this pull request Jan 5, 2024

Release/6.15.0-beta.4 #925

Merged


		private lateinit var channel : MethodChannel

		override fun onAttachedToEngine(flutterPluginBinding: FlutterPlugin.FlutterPluginBinding) {

Uh oh!

Conversation

tonidero commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonidero commented Jan 3, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tonidero commented Jan 3, 2024 •

edited

Loading