Skip to content

Require PR approval before release tagging#738

Merged
ajpallares merged 2 commits into
mainfrom
pallares/require-release-pr-approval
Mar 23, 2026
Merged

Require PR approval before release tagging#738
ajpallares merged 2 commits into
mainfrom
pallares/require-release-pr-approval

Conversation

@ajpallares

@ajpallares ajpallares commented Mar 20, 2026

Copy link
Copy Markdown
Member

Motivation

The release workflow currently allows tagging a release branch without verifying that the PR has been reviewed and approved. This adds a safeguard to ensure the release PR is properly approved before the tag is created.

Description

Bumps revenuecat/sdks-common-config orb to @3.16.0, which includes a validate_pr_approved step in the tag-current-branch job. This verifies the release PR has been approved by an org member with write permissions before the git tag is created.

Depends on: RevenueCat/sdks-circleci-orb#41

This version includes a `validate_pr_approved` check in `tag-current-branch`
that verifies the release PR has been approved before the tag is created.

Made-with: Cursor
@ajpallares ajpallares force-pushed the pallares/require-release-pr-approval branch from 7d0b5e5 to 82fd7c5 Compare March 20, 2026 17:41
@ajpallares ajpallares marked this pull request as ready for review March 23, 2026 11:24
@ajpallares ajpallares requested a review from a team as a code owner March 23, 2026 11:24
@ajpallares ajpallares merged commit f1288aa into main Mar 23, 2026
11 checks passed
@ajpallares ajpallares deleted the pallares/require-release-pr-approval branch March 23, 2026 11:44
RCGitBot added a commit that referenced this pull request Apr 1, 2026
**This is an automatic release.**

## RevenueCat SDK
### 📦 Dependency Updates
* Updates purchases-hybrid-common to 17.54.0 (#745) via RevenueCat Git
Bot (@RCGitBot)
* [Android
9.28.1](https://github.com/RevenueCat/purchases-android/releases/tag/9.28.1)
* [Android
9.28.0](https://github.com/RevenueCat/purchases-android/releases/tag/9.28.0)
* [Android
9.27.0](https://github.com/RevenueCat/purchases-android/releases/tag/9.27.0)
* [iOS
5.67.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.67.0)
* [iOS
5.66.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.66.0)
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 17.53.0 (#737) via
RevenueCat Git Bot (@RCGitBot)
* [Android
9.28.1](https://github.com/RevenueCat/purchases-android/releases/tag/9.28.1)
* [Android
9.28.0](https://github.com/RevenueCat/purchases-android/releases/tag/9.28.0)
* [Android
9.27.0](https://github.com/RevenueCat/purchases-android/releases/tag/9.27.0)
* [iOS
5.67.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.67.0)
* [iOS
5.66.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.66.0)

### 🔄 Other Changes
* fix: upgrade dependencies with known security vulnerabilities (#743)
via Cesar de la Vega (@vegaro)
* Bump fastlane-plugin-revenuecat_internal from `9a6911b` to `f11fe40`
(#742) via dependabot[bot] (@dependabot[bot])
* security: pin GitHub Actions to SHA hashes (#741) via Alfonso
Embid-Desmet (@alfondotnet)
* Merge release PR after deploy (#739) via Antonio Pallares
(@ajpallares)
* Add missing API tests for presentation configuration and
trackCustomPaywallImpression (#740) via Rick (@rickvdl)
* Require PR approval before release tagging (#738) via Antonio Pallares
(@ajpallares)
* Add API tests for purchases-capacitor and purchases-capacitor-ui
(#720) via Rick (@rickvdl)
* Add AGENTS.md for AI coding agent guidance (#696) via Facundo Menzella
(@facumenzella)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants