Skip to content

Generating new test snapshots for main#2

Merged
tonidero merged 3 commits into
mainfrom
generated_snapshots/main-20231102161624
Nov 3, 2023
Merged

Generating new test snapshots for main#2
tonidero merged 3 commits into
mainfrom
generated_snapshots/main-20231102161624

Conversation

@tonidero

@tonidero tonidero commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

Requested by local user for main

@tonidero tonidero added the test label Nov 2, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of images have the footer texts cut, not sure why it's not picking the shortened version

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the dark mode images are not really dark mode because we haven't added dark mode colors to those templates. We probably should, but we can do that later

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the localization is not working here. Seems like some snapshots are actually being localized but not all of them, need to look into it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks terrible. I hadn't noticed because I was testing in tablets using the dialog view which isn't so wide. We probably need to give a max height or something so the image doesn't take the whole screen considering the aspectRatio. Template 5 also has the same issue. Will probably fix that in followup PRs though.

@tonidero

tonidero commented Nov 3, 2023

Copy link
Copy Markdown
Collaborator Author

Going to merge this for now so I can get the snapshots working in purchases-android. We can fix the screenshots in future PRs.

@tonidero tonidero merged commit 958ca0c into main Nov 3, 2023
@tonidero tonidero deleted the generated_snapshots/main-20231102161624 branch November 3, 2023 09:55
tonidero added a commit to RevenueCat/purchases-android that referenced this pull request Nov 3, 2023
### Description
This uses paparazzi to test some basic combination matrix of the
different templates settings combinations. Currently testing each
template in:
- Pixel 6
- Pixel 6 landscape
- Pixel 6 dark mode
- Pixel 6 spanish
- Nexus 7
- Nexus 10

We might want to refine this list later on.

This is currently working locally, but need to test the CI side and will
also need to fix some issues discovered during this first pass.
Snapshots in:
RevenueCat/purchases-android-snapshots#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant