Add diagnostics tracking for BC5 google methods#876
Merged
tonidero merged 1 commit intoApr 5, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 84.79% 82.28% -2.51%
==========================================
Files 166 150 -16
Lines 5794 5381 -413
Branches 798 759 -39
==========================================
- Hits 4913 4428 -485
- Misses 563 671 +108
+ Partials 318 282 -36
... and 56 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Base automatically changed from
merge-main-bc5-support-2023-03-15
to
bc5-support
March 16, 2023 11:30
67e9fc7 to
4873a47
Compare
Contributor
Author
|
Thanks for the reviews! Holding until the backend part is merged. |
Member
|
@tonidero is the backend side merged already? if not, what's holding it back? |
Contributor
Author
|
Not yet, just asked @thecadams for a review. Hopefully we can get that deployed soon |
4873a47 to
72be5b6
Compare
Contributor
Author
|
Backend changes were deployed and tested that these diagnostics are sent without errors. Merging now. |
tonidero
added a commit
that referenced
this pull request
Apr 5, 2023
**This is an automatic release.** ### Bugfixes * Remove flavors temporarily to fix deployment (#953) via Toni Rico (@tonidero) ### Other Changes * Add diagnostics tracking for BC5 google methods (#876) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on https://github.com/RevenueCat/khepri/pull/5488
It's based off #875
Completes SDK-2965
This adds diagnostics tracking for Google's methods in the BC5 branch.