Skip to content

Improve entitlement verification documentation#870

Merged
tonidero merged 2 commits into
entitlements-verificationfrom
entitlement-verification-improve-documentation
Mar 15, 2023
Merged

Improve entitlement verification documentation#870
tonidero merged 2 commits into
entitlements-verificationfrom
entitlement-verification-improve-documentation

Conversation

@tonidero

Copy link
Copy Markdown
Contributor

Description

Improves the documentation for the Entitlement verification feature. Adding a note about the behavior when enabling entitlement verification.

@tonidero tonidero added the docs label Mar 14, 2023
@tonidero tonidero requested review from a team and aboedo March 14, 2023 12:21
@codecov

codecov Bot commented Mar 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #870 (0006189) into entitlements-verification (e8247ad) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##           entitlements-verification     #870      +/-   ##
=============================================================
- Coverage                      83.34%   83.30%   -0.05%     
=============================================================
  Files                            139      139              
  Lines                           4546     4546              
  Branches                         601      601              
=============================================================
- Hits                            3789     3787       -2     
  Misses                           540      540              
- Partials                         217      219       +2     
Impacted Files Coverage Δ
...com/revenuecat/purchases/PurchasesConfiguration.kt 94.44% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'm adding the same to iOS:
Screenshot 2023-03-14 at 08 58 19

Comment thread purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesConfiguration.kt Outdated
Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
@tonidero tonidero merged commit f40cb62 into entitlements-verification Mar 15, 2023
@tonidero tonidero deleted the entitlement-verification-improve-documentation branch March 15, 2023 08:14
tonidero added a commit that referenced this pull request Mar 15, 2023
### Description
Improves the documentation for the Entitlement verification feature.
Adding a note about the behavior when enabling entitlement verification.

---------

Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
@tonidero tonidero mentioned this pull request Mar 31, 2023
@vegaro vegaro added pr:other and removed pr:docs labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants