Entitlement verification: Send updated value in listener when verification result changes#856
Merged
tonidero merged 1 commit intoMar 14, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## entitlements-verification #856 +/- ##
==========================================================
Coverage 83.28% 83.28%
==========================================================
Files 139 139
Lines 4546 4548 +2
Branches 600 602 +2
==========================================================
+ Hits 3786 3788 +2
Misses 540 540
Partials 220 220
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NachoSoto
approved these changes
Mar 13, 2023
tonidero
added a commit
that referenced
this pull request
Mar 15, 2023
…ation result changes (#856) ### Description We were not sending updated values in the listener when we only detected a change in the verification result. This fixes that by adding this new property to the equals calculation.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were not sending updated values in the listener when we only detected a change in the verification result. This fixes that by adding this new property to the equals calculation.