Entitlement verification: Hide EntitlementVerificationMode.ENFORCED during beta and improve documentation#852
Merged
tonidero merged 2 commits intoMar 14, 2023
Conversation
f627da9 to
2f307b3
Compare
Codecov Report
@@ Coverage Diff @@
## entitlements-verification #852 +/- ##
=============================================================
+ Coverage 83.28% 83.29% +0.01%
=============================================================
Files 139 139
Lines 4546 4544 -2
Branches 600 599 -1
=============================================================
- Hits 3786 3785 -1
Misses 540 540
+ Partials 220 219 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NachoSoto
approved these changes
Mar 13, 2023
tonidero
added a commit
that referenced
this pull request
Mar 15, 2023
…uring beta and improve documentation (#852) ### Description Completes [SDK-2923](https://linear.app/revenuecat/issue/SDK-2923/hide-enforced-mode-for-sdk-security). We decided to pull the ENFORCED mode during beta of the entitlements verification feature. This PR also improves and adds some missing documentation. Note that the internal `SignatureVerificationMode.enforced` still exists and tests remain, but it won't be available through the public API.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes SDK-2923.
We decided to pull the ENFORCED mode during beta of the entitlements verification feature. This PR also improves and adds some missing documentation.
Note that the internal
SignatureVerificationMode.enforcedstill exists and tests remain, but it won't be available through the public API.