Entitlement verification: Return current call verification result over cached version#842
Merged
tonidero merged 2 commits intoMar 7, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## entitlement-verification-rename-not-verified-to-not-requested #842 +/- ##
==============================================================================================
Coverage 82.61% 82.61%
==============================================================================================
Files 137 137
Lines 4498 4499 +1
Branches 584 585 +1
==============================================================================================
+ Hits 3716 3717 +1
Misses 562 562
Partials 220 220
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonidero
commented
Mar 6, 2023
Contributor
Author
There was a problem hiding this comment.
Improved this test to make sure we don't check with etag manager when verification errors and verification mode is enforced.
Contributor
Author
|
Moving back to draft after the latest conversation in slack |
1614b23 to
001763c
Compare
NachoSoto
approved these changes
Mar 7, 2023
Base automatically changed from
entitlement-verification-rename-not-verified-to-not-requested
to
entitlements-verification
March 7, 2023 17:28
a88f8d6 to
2c0b25f
Compare
tonidero
added a commit
that referenced
this pull request
Mar 15, 2023
…r cached version (#842) ### Description This PR makes sure we expose the current call verification result over the cached version. We shouldn't be storing verification errors in the etag cache. Also, we plan to clear the cache when verification mode is enabled, so we shouldn't have `NOT_REQUESTED` values either, so the etag cache should only contain successful values
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure we expose the current call verification result over the cached version. We shouldn't be storing verification errors in the etag cache. Also, we plan to clear the cache when verification mode is enabled, so we shouldn't have
NOT_REQUESTEDvalues either, so the etag cache should only contain successful values