Entitlement verification: Rename not verified to not requested and error to failed#838
Merged
tonidero merged 3 commits intoMar 7, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## entitlements-verification #838 +/- ##
==========================================================
Coverage 82.61% 82.61%
==========================================================
Files 137 137
Lines 4498 4498
Branches 584 584
==========================================================
Hits 3716 3716
Misses 562 562
Partials 220 220
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NachoSoto
approved these changes
Mar 7, 2023
tonidero
added a commit
that referenced
this pull request
Mar 15, 2023
…ror to failed (#838) ### Description Following the conversation in [SDK-2896](https://linear.app/revenuecat/issue/SDK-2896/invalidate-devicecache-cache-if-entitlement-verification-is-missing), we are renaming `NOT_VERIFIED` to `NOT_REQUESTED`. We're also renaming `ERROR` to `FAILED` to match iOS.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the conversation in SDK-2896, we are renaming
NOT_VERIFIEDtoNOT_REQUESTED. We're also renamingERRORtoFAILEDto match iOS.