Diagnostics: Track google query methods#807
Conversation
There was a problem hiding this comment.
I foresee a complicated merge conflict with BC5 once we support it... So I decided to just add the functionality to the BC4 version for now. My plan is to create a ticket to just do this again in the BC5 integration branch after it's been merged to main and to that branch. Lmk if you have any concerns over that.
There was a problem hiding this comment.
We were not cleaning mocks for all these tests afaik, which is surprising... I'm not sure if mockk is clearing mocks automatically on its own on each test... But in any case, I thought clearing mocks manually was safer. I would actually prefer to recreate all the mocks on each test, but this should also work.
Codecov Report
@@ Coverage Diff @@
## diagnostics #807 +/- ##
==============================================
Coverage ? 82.41%
==============================================
Files ? 130
Lines ? 4323
Branches ? 548
==============================================
Hits ? 3563
Misses ? 543
Partials ? 217 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Just added some milliseconds difference to test response times.
There was a problem hiding this comment.
Not tracking amazon requests yet.
72d72e2 to
8ef8322
Compare
a7b2e69 to
75e3d5e
Compare
|
Tests are failing due to Sdkman but they are passing locally and since this is being merged to a non-main branch, will merge it for now. Will deal with those issues in that branch. |
Description
This PR adds 3 new diagnostics events:
These events will be tracked when hitting the corresponding Google query methods.