Diagnostics: Adapt to latest backend changes#805
Merged
Conversation
tonidero
commented
Feb 16, 2023
Contributor
Author
There was a problem hiding this comment.
I'm still confirming whether we need to send any metrics. But if not, we can probably just remove DiagnosticsEntry entirely and just leave DiagnosticsEvent as a data class.
Codecov Report
@@ Coverage Diff @@
## diagnostics #805 +/- ##
==============================================
Coverage ? 82.36%
==============================================
Files ? 130
Lines ? 4309
Branches ? 549
==============================================
Hits ? 3549
Misses ? 543
Partials ? 217 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bd7a0cc to
a68057b
Compare
132edab to
58a7507
Compare
NachoSoto
approved these changes
Feb 21, 2023
a68057b to
92e0085
Compare
Base automatically changed from
diagnostics-increase-jittering-diagnostics-calls
to
diagnostics
February 22, 2023 11:19
72d72e2 to
8ef8322
Compare
Contributor
Author
|
Tests are failing due to Sdkman but they are passing locally and since this is being merged to a non-main branch, will merge it for now. Will deal with those issues in that branch. |
tonidero
added a commit
that referenced
this pull request
Feb 22, 2023
### Description This PR we are adapting the code to the latest changes in the backend. ### Changes - We've removed `exceptions` as a type of diagnostic, those can be sent as a Log/Event - We've renamed `DiagnosticsEvent` to `DiagnosticsEntry` - We've renamed `DiagnosticsEvent.Log` to `DiagnosticsEntry.Event` - Renamed "type" of `DiagnosticsEntry.Event` to `event` - Enabled diagnostics and verbose logs in purchase tester.
tonidero
added a commit
that referenced
this pull request
Feb 28, 2023
### Description This PR we are adapting the code to the latest changes in the backend. ### Changes - We've removed `exceptions` as a type of diagnostic, those can be sent as a Log/Event - We've renamed `DiagnosticsEvent` to `DiagnosticsEntry` - We've renamed `DiagnosticsEvent.Log` to `DiagnosticsEntry.Event` - Renamed "type" of `DiagnosticsEntry.Event` to `event` - Enabled diagnostics and verbose logs in purchase tester.
tonidero
added a commit
that referenced
this pull request
Feb 28, 2023
### Description This PR we are adapting the code to the latest changes in the backend. ### Changes - We've removed `exceptions` as a type of diagnostic, those can be sent as a Log/Event - We've renamed `DiagnosticsEvent` to `DiagnosticsEntry` - We've renamed `DiagnosticsEvent.Log` to `DiagnosticsEntry.Event` - Renamed "type" of `DiagnosticsEntry.Event` to `event` - Enabled diagnostics and verbose logs in purchase tester.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR we are adapting the code to the latest changes in the backend.
Changes
exceptionsas a type of diagnostic, those can be sent as a Log/EventDiagnosticsEventtoDiagnosticsEntryDiagnosticsEvent.LogtoDiagnosticsEntry.EventDiagnosticsEntry.Eventtoevent