Skip to content

Diagnostics: Increase jittering for diagnostics backend calls#804

Merged
tonidero merged 2 commits into
diagnosticsfrom
diagnostics-increase-jittering-diagnostics-calls
Feb 22, 2023
Merged

Diagnostics: Increase jittering for diagnostics backend calls#804
tonidero merged 2 commits into
diagnosticsfrom
diagnostics-increase-jittering-diagnostics-calls

Conversation

@tonidero

Copy link
Copy Markdown
Contributor

Description

Deals with SDK-2865

This increases the jittering we add for diagnostics calls to make sure they don't cause any interference with the main SDK calls.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the diagnostics call will always have jittering

@tonidero tonidero marked this pull request as ready for review February 16, 2023 13:52
@tonidero tonidero requested a review from a team February 16, 2023 13:52
@codecov

codecov Bot commented Feb 16, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (diagnostics@e864f32). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 68ab50a differs from pull request most recent head 92e0085. Consider uploading reports for the commit 92e0085 to get more accurate results

@@              Coverage Diff               @@
##             diagnostics     #804   +/-   ##
==============================================
  Coverage               ?   82.35%           
==============================================
  Files                  ?      130           
  Lines                  ?     4308           
  Branches               ?      547           
==============================================
  Hits                   ?     3548           
  Misses                 ?      543           
  Partials               ?      217           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tonidero tonidero force-pushed the diagnostics-track-endpoint-hit branch from 9c954f3 to dfa2575 Compare February 17, 2023 08:17
@tonidero tonidero force-pushed the diagnostics-increase-jittering-diagnostics-calls branch 2 times, most recently from bd7a0cc to a68057b Compare February 17, 2023 08:59
Base automatically changed from diagnostics-track-endpoint-hit to diagnostics February 22, 2023 11:11
@tonidero tonidero force-pushed the diagnostics-increase-jittering-diagnostics-calls branch from a68057b to 92e0085 Compare February 22, 2023 11:13
@tonidero

Copy link
Copy Markdown
Contributor Author

Tests are failing due to Sdkman but they are passing locally and since this is being merged to a non-main branch, will merge it for now. Will deal with those issues in that branch.

@tonidero tonidero merged commit 3995f0a into diagnostics Feb 22, 2023
@tonidero tonidero deleted the diagnostics-increase-jittering-diagnostics-calls branch February 22, 2023 11:19
tonidero added a commit that referenced this pull request Feb 22, 2023
### Description
Deals with
[SDK-2865](https://linear.app/revenuecat/issue/SDK-2865/add-random-jitter-to-diagnostics-requests)

This increases the jittering we add for diagnostics calls to make sure
they don't cause any interference with the main SDK calls.
tonidero added a commit that referenced this pull request Feb 28, 2023
### Description
Deals with
[SDK-2865](https://linear.app/revenuecat/issue/SDK-2865/add-random-jitter-to-diagnostics-requests)

This increases the jittering we add for diagnostics calls to make sure
they don't cause any interference with the main SDK calls.
tonidero added a commit that referenced this pull request Feb 28, 2023
### Description
Deals with
[SDK-2865](https://linear.app/revenuecat/issue/SDK-2865/add-random-jitter-to-diagnostics-requests)

This increases the jittering we add for diagnostics calls to make sure
they don't cause any interference with the main SDK calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants