[FINAL] Add a Test#8
Merged
Merged
Conversation
This was referenced Apr 9, 2026
tonidero
pushed a commit
that referenced
this pull request
Apr 15, 2026
…#3324) ### Motivation Resolves #3321 The ripple effect in Paywalls V2 ignores rounded corners and extends into the component's margin area. This happens because `Modifier.clickable()` is applied before `StackComponentView` applies `.clip(shape)` and margin internally — so the ripple fills the entire rectangular area including margins. ### Description Introduces an `interactionModifier` parameter on `StackComponentView` that gets threaded down to `MainStackComponent` and applied **after** `.clip(composeShape)` in all 4 code paths (standard, video background, nested badge, overlay). This ensures the ripple is bounded by the component's actual shape. Updated all callers: - **ButtonComponentView** — moves `clickable` into `interactionModifier` - **PackageComponentView** — moves conditional `clickable` into `interactionModifier`, removes unused `conditional` import - **TabControlButtonView** — moves `clickable` into `interactionModifier` Also adds a `ButtonComponent` to the bless sample paywall (#8) to make it easier to reproduce and verify the fix visually. **Testing:** All existing unit tests pass — StackComponentViewTests, StackComponentViewWindowTests, ButtonComponentViewTests, PackageComponentViewTests, TabsComponentViewTests. Verified visually via the updated sample paywall. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches the core `StackComponentView` container and changes where click/interaction modifiers are applied, which could subtly affect touch targets and interaction behavior across multiple paywall components. Functionality is UI-scoped (ripple/press feedback) with no data/auth implications. > > **Overview** > Fixes Compose ripple/press feedback on paywall components so it respects rounded corners and does not extend into margins by adding an `interactionModifier` to `StackComponentView` and applying it **after** `clip(shape)` across all rendering paths (standard, video background, nested badge, overlay/badge variants). > > Updates callers (`ButtonComponentView`, `PackageComponentView`, `TabControlButtonView`) to pass their `Modifier.clickable` via `interactionModifier` (instead of on the outer `modifier`), and tweaks the paywall tester sample (#8) to use a `ButtonComponent` to make the issue easy to reproduce/verify. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c7368b0. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.