Skip to content

Add queries#788

Merged
swehner merged 1 commit into
amazon-pocfrom
amazon-poc-stefan
Feb 10, 2023
Merged

Add queries#788
swehner merged 1 commit into
amazon-pocfrom
amazon-poc-stefan

Conversation

@swehner

@swehner swehner commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-ios and hybrids

Motivation

This was needed to make the purchases_sample work with the AmazonAppTester on my Fire device

@swehner swehner requested a review from beylmk February 10, 2023 15:23
@RevenueCat-Danger-Bot

RevenueCat-Danger-Bot commented Feb 10, 2023

Copy link
Copy Markdown
1 Error
🚫 Label the PR using one of the change type labels
Label Description
breaking Changes that are breaking
build Changes that affect the build system
ci Changes to our CI configuration files and scripts
docs Documentation only changes
feat A new feature
fix A bug fix
perf A code change that improves performance
refactor A code change that neither fixes a bug nor adds a feature
style Changes that don't affect the meaning of the code (white-space, formatting, missing semi-colons, etc
test Adding missing tests or correcting existing tests
next_release Preparing a new release
dependencies Updating a dependency
phc_dependencies Updating purchases-hybrid-common dependency

Generated by 🚫 Danger

tonidero
tonidero approved these changes Feb 10, 2023
View reviewed changes

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

tonidero
tonidero reviewed Feb 10, 2023
View reviewed changes
Comment thread examples/purchase-tester/src/main/AndroidManifest.xml
</application>
<queries>
<package android:name="com.amazon.sdktestclient" />
</queries>

@tonidero tonidero Feb 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about moving this to the feature/amazon package manifest, but that's probably a bad idea since we would make our app's users potentially have this as well. So this is good 👍

@swehner swehner added the bug label Feb 10, 2023
@swehner swehner merged commit 3d90b4e into amazon-poc Feb 10, 2023
@swehner swehner deleted the amazon-poc-stefan branch February 10, 2023 15:59
@tonidero tonidero mentioned this pull request Feb 10, 2023
Merged
@swehner swehner restored the amazon-poc-stefan branch February 10, 2023 16:35
@swehner swehner deleted the amazon-poc-stefan branch February 10, 2023 16:36
swehner added a commit that referenced this pull request Feb 13, 2023
@swehner
Add queries (#788)
2b1375d 
<!-- Thank you for contributing to Purchases! Before pressing the
"Create Pull Request" button, please provide the following: -->

### Checklist
- [ ] If applicable, unit tests
- [ ] If applicable, create follow-up issues for `purchases-ios` and
hybrids

### Motivation
This was needed to make the purchases_sample work with the
AmazonAppTester on my Fire device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonidero tonidero tonidero approved these changes
@beylmk beylmk Awaiting requested review from beylmk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swehner @RevenueCat-Danger-Bot @tonidero