Remove tag_release_with_latest_if_needed fastlane lane#781
Merged
Conversation
tag_release_with_latest_if_needed fastlane lane
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 121 121
Lines 3999 3999
Branches 512 512
=======================================
Hits 3261 3261
Misses 535 535
Partials 203 203 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Feb 9, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with the change, but we should remember to remove the latest tag after this is merged to avoid it becoming outdated.
Member
|
do we actually need it, though? which docs are pointing to it? Maybe we can update the docs instead? |
Member
Author
@aboedo we are moving the tag to the latest release on every release already. I don't think the docs ever pointed to it actually. It was intended to be able to link to the latest release from docs.revenuecat.com, but we are not doing that at the moment. |
Member
Author
|
I actually just checked and it's even pointing to 6.0.0-alpha.3 instead of 5.7.1 (the actual latest), so it's not even working properly 😆 |
tonidero
added a commit
that referenced
this pull request
Mar 2, 2023
**This is an automatic release.** ### New Features * Diagnostics (#811) via Toni Rico (@tonidero) ### Dependency Updates * Bump fastlane from 2.212.0 to 2.212.1 (#821) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.211.0 to 2.212.0 (#808) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-versioning_android from 0.1.0 to 0.1.1 (#798) via dependabot[bot] (@dependabot[bot]) * Bump danger from 8.6.1 to 9.2.0 (#778) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Fix bundle install on CircleCI (#827) via Cesar de la Vega (@vegaro) * Update README.md to include minimum Kotlin version (#786) via Cesar de la Vega (@vegaro) * Remove `tag_release_with_latest_if_needed` fastlane lane (#781) via Cesar de la Vega (@vegaro) * Adds docs for timeouts when closing and releasing (#759) via Cesar de la Vega (@vegaro) * Add Amazon App tester package to purchase tester queries (#789) via Stefan Wehner (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Mar 9, 2023
## 5.8.2⚠️ ⚠️ ⚠️ ⚠️ Android SDK versions 5.8.0 and 5.8.1 have a major bug that prevents sending purchase tokens to RevenueCat. Users will get charged but won't receive entitlements. An automatic refund will occur after 72 hours unless an unaffected SDK version is used. Downgrade to 5.7.1 or upgrade to 5.8.2 or later to avoid this bug. Users who got charged while using 5.8.0 and 5.8.1 will be able to access their purchases automatically upon opening an app that uses 5.7.1 or lower, or 5.8.2 or higher.⚠️ ⚠️ ⚠️ ⚠️ ### Other changes in 5.8.0 and 5.8.1 ### New Features * Diagnostics (#811) via Toni Rico (@tonidero) ### Bugfixes * Fix issue with missing subscriber attributes if set after login but before login callback (#809) via Toni Rico (@tonidero) ### Dependency Updates * Bump fastlane from 2.212.0 to 2.212.1 (#821) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.211.0 to 2.212.0 (#808) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-versioning_android from 0.1.0 to 0.1.1 (#798) via dependabot[bot] (@dependabot[bot]) * Bump danger from 8.6.1 to 9.2.0 (#778) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Fix docs deployment (#836) via Toni Rico (@tonidero) * Fix SDKMAN issues (#822) via Toni Rico (@tonidero) * Fix bundle install on CircleCI (#827) via Cesar de la Vega (@vegaro) * Update README.md to include minimum Kotlin version (#786) via Cesar de la Vega (@vegaro) * Remove `tag_release_with_latest_if_needed` fastlane lane (#781) via Cesar de la Vega (@vegaro) * Adds docs for timeouts when closing and releasing (#759) via Cesar de la Vega (@vegaro) * Add Amazon App tester package to purchase tester queries (#789) via Stefan Wehner (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe we are not using the
latesttag for anything. We were using it to point to the latest version from the docs