Skip to content

Diagnostics: Backend integration#771

Closed
tonidero wants to merge 5 commits into
telemetryfrom
telemetry-backend-integration
Closed

Diagnostics: Backend integration#771
tonidero wants to merge 5 commits into
telemetryfrom
telemetry-backend-integration

Conversation

@tonidero

@tonidero tonidero commented Feb 3, 2023 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Based off #766.
Deals with CSDK-647 and CSDK-648

This PR adds support for the backend request of the telemetry feature. We will gzip compress the request to save data usage.

This PR still hasn't been tested against the backend currently.

@tonidero tonidero added pr:feat A new feature WIP labels Feb 3, 2023
@codecov

codecov Bot commented Feb 3, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #771 (3e43959) into telemetry (6255231) will increase coverage by 0.14%.
The diff coverage is 89.77%.

@@              Coverage Diff              @@
##           telemetry     #771      +/-   ##
=============================================
+ Coverage      81.97%   82.11%   +0.14%     
=============================================
  Files            127      127              
  Lines           4127     4189      +62     
  Branches         521      531      +10     
=============================================
+ Hits            3383     3440      +57     
- Misses           535      536       +1     
- Partials         209      213       +4
Impacted Files Coverage Δ
...java/com/revenuecat/purchases/common/HTTPClient.kt 79.56% <77.77%> (-1.55%) ⬇️
...in/java/com/revenuecat/purchases/common/Backend.kt 84.36% <89.36%> (+1.02%) ⬆️
...purchases/common/diagnostics/DiagnosticsManager.kt 95.65% <91.30%> (+2.54%) ⬆️
...chases/common/diagnostics/DiagnosticsFileHelper.kt 80.00% <100.00%> (+2.22%) ⬆️
...enuecat/purchases/common/networking/HTTPRequest.kt 100.00% <100.00%> (ø)
...otlin/com/revenuecat/purchases/PurchasesFactory.kt 92.68% <100.00%> (+0.27%) ⬆️
...ain/java/com/revenuecat/purchases/common/errors.kt 75.92% <0.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aboedo
aboedo reviewed Feb 3, 2023
View reviewed changes
Comment thread common/src/main/java/com/revenuecat/purchases/common/HTTPClient.kt Outdated
@tonidero tonidero force-pushed the telemetry-backend-integration branch 2 times, most recently from 815b18f to 1c86669 Compare February 7, 2023 14:02
@tonidero tonidero force-pushed the telemetry-backend-integration branch from 113a03b to 086d22e Compare February 9, 2023 09:17
@tonidero tonidero changed the title Telemetry: Backend integration Diagnostics: Backend integration Feb 9, 2023
This was referenced Feb 9, 2023
Closed
Merged
@tonidero

tonidero commented Feb 9, 2023

Copy link
Copy Markdown
Contributor Author

I'm closing this in favor of new PRs that better split the code: #783, #784, #785

@tonidero tonidero closed this Feb 9, 2023
@tonidero tonidero deleted the telemetry-backend-integration branch March 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aboedo aboedo aboedo left review comments

Assignees

No one assigned

Labels

pr:feat A new feature WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonidero @aboedo