Conversation
…Manager. Adding tests
Codecov Report
@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 81.54% 81.97% +0.42%
==========================================
Files 121 127 +6
Lines 3999 4127 +128
Branches 512 521 +9
==========================================
+ Hits 3261 3383 +122
Misses 535 535
- Partials 203 209 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonidero
commented
Feb 2, 2023
tonidero
left a comment
Contributor
Author
There was a problem hiding this comment.
There is some functionality missing which I plan to address in other PRs since this PR was getting too big. I also have some questions I posted in slack but in the meantime, I think this could get an initial review.
| onSuccessHandler: (JSONObject) -> Unit, | ||
| onErrorHandler: (PurchasesError) -> Unit | ||
| ) { | ||
| // WIP: Perform request |
Contributor
Author
There was a problem hiding this comment.
Will deal with these WIPs in a different PR (this PR is already too big)
| telemetryList = telemetryList, | ||
| onSuccessHandler = { | ||
| verboseLog("Synced telemetry file successfully.") | ||
| telemetryFileHelper.cleanSentTelemetry(telemetryCount) |
Contributor
Author
There was a problem hiding this comment.
This is so, if we track an event while there is a sync in progress, we still send it on the next configure call.
NachoSoto
reviewed
Feb 2, 2023
| import org.json.JSONArray | ||
| import org.json.JSONObject | ||
|
|
||
| sealed class TelemetryEvent(val telemetryType: String) { |
NachoSoto
reviewed
Feb 2, 2023
NachoSoto
reviewed
Feb 2, 2023
NachoSoto
left a comment
Contributor
There was a problem hiding this comment.
This is a great initial implementation 👍🏻
Will be very easy to replicate in iOS.
NachoSoto
reviewed
Feb 6, 2023
aboedo
reviewed
Feb 8, 2023
This was referenced Feb 9, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting https://revenuecats.atlassian.net/browse/CSDK-646
In this PR we add basic support for diagnostics metrics we want to be aware of. The data sent will be completely anonymous. This PR adds the basic architecture plus the file management in the device.
Main features remaining: