Fix crash when cleaning old attribution data if SharedPreferences has a null key#742
Merged
Conversation
aboedo
approved these changes
Jan 17, 2023
aboedo
approved these changes
Jan 17, 2023
Co-authored-by: Andy Boedo <andresboedo@gmail.com>
tonidero
pushed a commit
that referenced
this pull request
Jan 19, 2023
**This is an automatic release.** ### Bugfixes * Fix crash when cleaning old attribution data if SharedPreferences has a null key (#742) via Toni Rico (@tonidero) ### Other Changes * Update Gemfile.lock (#734) via Cesar de la Vega (@vegaro) * remove stalebot in favor of SLAs in Zendesk (#725) via Andy Boedo (@aboedo) * Update fastlane-plugin-revenuecat_internal to latest version (#724) via Cesar de la Vega (@vegaro) * Bumps AGP to 7.3.1 (#718) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deals with #737
If devs store something in SharedPreferences with a null key, it can cause a crash the next time the SDK is configured. This PR just ignores that key when cleaning up SDK values from SharedPreferences.