refactor(remote-config): wire-format models#3610
Merged
tonidero merged 4 commits intoJun 19, 2026
Merged
Conversation
This was referenced Jun 16, 2026
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3610 +/- ##
==========================================
- Coverage 80.31% 80.25% -0.06%
==========================================
Files 378 379 +1
Lines 15503 15530 +27
Branches 2154 2163 +9
==========================================
+ Hits 12451 12464 +13
- Misses 2193 2202 +9
- Partials 859 864 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fb82861 to
dd4061d
Compare
17f6f5d to
e30cd22
Compare
dd4061d to
e4eb551
Compare
e4eb551 to
f50eab9
Compare
e30cd22 to
c161d23
Compare
f50eab9 to
1468860
Compare
1 task
c161d23 to
e730be7
Compare
1468860 to
18695d1
Compare
a8a7b1f to
db36f20
Compare
7df7393 to
18e1888
Compare
db36f20 to
6a666b9
Compare
6a666b9 to
cea3fa5
Compare
3799228 to
aca57d7
Compare
cea3fa5 to
a7bc2cc
Compare
aca57d7 to
c07f7b1
Compare
a7bc2cc to
aad99b8
Compare
📸 Snapshot Test593 unchanged
🛸 Powered by Emerge Tools |
aad99b8 to
99fa878
Compare
c07f7b1 to
86e78b3
Compare
rickvdl
approved these changes
Jun 19, 2026
rickvdl
left a comment
Member
There was a problem hiding this comment.
Nice! I think this is looking great :) Just two questions
…affolding Add spec-shaped ConfigurationResponse / ConfigManifest / ConfigTopic / ConfigItem models plus a lenient parser for the config element (element 0 JSON). No behavior wired. Delete the pre-spec remote-config scaffolding (RemoteConfigResponse, RemoteConfigManager, TopicFetcher, RemoteConfigDiskCache and their tests): all of it was unreachable from production and modelled an older JSON shape. Later phases rebuild orchestration/disk-cache/blob-store on the new models. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
99fa878 to
c8d4706
Compare
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RemoteConfiguration.kt:RemoteConfiguration,RemoteConfiguration.Manifest,ConfigTopic,RemoteConfiguration.ConfigItemNote
Low Risk
Additive internal parsing models with no runtime wiring yet; behavior is covered by unit tests and does not touch purchases or auth paths.
Overview
Introduces internal kotlinx-serialization models for the
/v2/configJSON payload (RemoteConfiguration, nestedManifest, and per-topicConfigItemmaps), plusRemoteConfiguration.parse(bytes)using lenientJsonProvider.defaultJson.The shape matches incremental sync:
manifestlists every topic etag (and prefetch/refresh metadata), whiletopicscarries only changed topic bodies.ConfigItemSerializertreatsblob_ref/prefetchas reserved keys and keeps all other fields in aJsonObjectcontentso inline and blob-referenced items stay forward-compatible through persist round-trips.Adds
RemoteConfigurationTestcovering full/delta/empty-topic responses, unknown topics, inline vs blob items, defaults, and parse failures.Reviewed by Cursor Bugbot for commit b6031a0. Bugbot is set up for automated code reviews on this repo. Configure here.