Add exit offers support to workflows by vegaro · Pull Request #3452 · RevenueCat/purchases-android

vegaro · 2026-05-07T15:21:06Z

Summary

Adds workflow exit-offer support by carrying exit_offers from workflow screens into paywall component data, then preloading the configured dismiss offering for paywall activity/dialog dismissal flows.

The exit offer is resolved from the canonical workflow step: single_step_fallback_id when present, otherwise the terminal step discovered by walking the workflow graph. Preloading is now resilient to the activity/dialog calling preloadExitOffering() before workflow data has finished loading.

Fixes

Dismiss exit offers are now gated to the workflow step that owns the exit-offer config. If the user dismisses on an earlier workflow screen, the preloaded exit offering is ignored and the paywall closes normally. If the user dismisses on the latest/canonical screen, the exit offer is shown.

The view model also guards stale async offering/workflow loads with a revision counter so older loads cannot overwrite newer exit-offer data.

Testing

./gradlew :ui:revenuecatui:testDefaultsBc8DebugUnitTest --tests "com.revenuecat.purchases.ui.revenuecatui.data.PaywallViewModelWorkflowTest"
./gradlew :ui:revenuecatui:testDefaultsBc7DebugUnitTest --tests "com.revenuecat.purchases.ui.revenuecatui.data.PaywallViewModelWorkflowTest"
./gradlew :purchases:testDefaultsBc8DebugUnitTest --tests "com.revenuecat.purchases.common.workflows.*" :ui:revenuecatui:testDefaultsBc8DebugUnitTest --tests "com.revenuecat.purchases.ui.revenuecatui.workflow.WorkflowScreenMapperTest"
./gradlew detektAll

Note

Medium Risk
Updates paywall dismissal behavior and exit-offer preloading for workflow-driven paywalls, which can affect close flows and offering resolution. Risk is moderate due to new state management around async updates and step-gated exit offers.

Overview
Adds workflow-level support for exit_offers by deserializing them on WorkflowScreen and mapping them through WorkflowScreenMapper into PaywallComponentsData.

Enhances workflow models with PublishedWorkflow.dismissExitOffer (and WorkflowExitOffer) to resolve the dismiss exit-offer offering from the canonical step (single_step_fallback_id).

Refactors PaywallViewModelImpl exit-offer handling to a dedicated ExitOfferData state, enabling safe preloading even if preloadExitOffering() is called before workflow/offering data arrives, and gating dismiss exit-offers to only trigger when the user closes on the configured workflow step.

Adds focused unit tests covering canonical-step resolution, preload timing, offering refresh behavior, and close-paywall integration with dismissRequestWithExitOffering.

^{Reviewed by Cursor Bugbot for commit 070e138. Bugbot is set up for automated code reviews on this repo. Configure here.}

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Covers the two resilience cases: field present is parsed correctly, field absent (e.g. removed from backend) defaults to null without error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ows/PublishedWorkflowSerializationTest.kt

…adExitOffering Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

codecov · 2026-05-08T07:19:43Z

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.57%. Comparing base (1bfed5e) to head (070e138).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...uecat/purchases/common/workflows/WorkflowModels.kt	66.66%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3452      +/-   ##
==========================================
+ Coverage   79.55%   79.57%   +0.01%     
==========================================
  Files         365      365              
  Lines       14681    14690       +9     
  Branches     2002     2006       +4     
==========================================
+ Hits        11680    11689       +9     
+ Misses       2191     2188       -3     
- Partials      810      813       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Nothing observes it for recomposition. closePaywall reads it imperatively, so the MutableState/State machinery was pure overhead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

facumenzella · 2026-05-11T07:35:23Z

+    }
+
+    private var exitOfferData: ExitOfferData = ExitOfferData.Loading
+    private var preloadExitOfferingRequested = false


I wonder if we could put this into ExitOfferData to avoid having a separate boolean. something like an idle state, or requested state

agreed. Attempted some clean up in 39829fc. What do you think

facumenzella

a few nits, but looks great 🚀

resolveIfNeeded had no way to distinguish "not yet resolved" from "resolved but offering not found" — both left preloadedOffering=null, so the guard (preloadedOffering != null) never fired for the failure case. Every locale/colour/options refresh reset exitOfferData through an intermediate Loading() that erased any prior resolution, causing the not-found lookup and its error log to repeat on each refresh. Adds preloadAttempted: Boolean to ExitOfferData.Configured as a proper terminal flag. The guard in resolveIfNeeded is updated to check preloadAttempted instead of preloadedOffering != null, and both success and failure paths now set it to true. cancelAndResetState no longer resets exit offer data to Loading; that intermediate state served no purpose for exit offers and was the structural cause of the state loss. updateExitOfferData carries forward a completed resolution when the same offeringId is re-set with the same availability, but lets resolveIfNeeded run again if fresh offerings now contain the previously-missing offering. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> much simpler

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d3cbb91. Configure here.}

@RCGitBot

**This is an automatic release.** ## RevenueCat SDK ### 📦 Dependency Updates * [RENOVATE] Update dependency gradle to v8.14.5 (#3459) via RevenueCat Git Bot (@RCGitBot) ## RevenueCatUI SDK ### ✨ New Features * Pre-warm image cache for workflow step states (#3447) via Cesar de la Vega (@vegaro) ### Paywallv2 #### ✨ New Features * Add `close_workflow` button action (#3453) via Cesar de la Vega (@vegaro) #### 🐞 Bugfixes * Fix preload VideoComponent fallback override images (#3449) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Select blob source by priority and weighted random (#3458) via Toni Rico (@tonidero) * [AUTOMATIC] Update golden test files for backend integration tests (#3473) via RevenueCat Git Bot (@RCGitBot) * Clean up unreferenced topic files after successful remote-config refresh (#3439) via Toni Rico (@tonidero) * Cache remote config response in memory with TTL and persist to disk (#3457) via Toni Rico (@tonidero) * build(deps): bump fastlane from 2.233.1 to 2.234.0 (#3463) via dependabot[bot] (@dependabot[bot]) * Update codelabs links (#3460) via Jaewoong Eum (@skydoves) * Add RemoteConfigManager and TopicFetcher (#3437) via Toni Rico (@tonidero) * Add exit offers support to workflows (#3452) via Cesar de la Vega (@vegaro) * Update baseline profiles (#3461) via RevenueCat Git Bot (@RCGitBot) * Add network scaffolding for remote config endpoint (#3435) via Toni Rico (@tonidero) * test: cover singleStepFallbackId == initialStepId edge case (#3445) via Facundo Menzella (@facumenzella)  --- > [!NOTE] > **Low Risk** > Low risk: this is a release/versioning update (SNAPSHOT -> final) plus docs deployment path changes, with no functional code changes beyond version constants. > > **Overview** > Finalizes the `10.6.0` release by switching all version references from `10.6.0-SNAPSHOT` to `10.6.0` (root `.version`, `gradle.properties`, `Config.frameworkVersion`, and sample/test app `libs.versions.toml` files). > > Updates documentation publishing to point at the `10.6.0` docs path (CircleCI S3 sync target and `docs/index.html` redirect), and prepends the `10.6.0` section to `CHANGELOG.md`/`CHANGELOG.latest.md`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4da1697. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

vegaro and others added 6 commits May 7, 2026 17:08

feat: add exit offer support for workflow paywalls

6013fe6

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: address code review feedback on workflow exit offers

57085be

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: verify single_step_fallback_id JSON deserialization

0aeb531

Covers the two resilience cases: field present is parsed correctly, field absent (e.g. removed from backend) defaults to null without error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Delete purchases/src/test/java/com/revenuecat/purchases/common/workfl…

d1af2af

…ows/PublishedWorkflowSerializationTest.kt

findCanonicalExitOfferStep

f05df93

fix: wait for paywall state before reading exit offer config in prelo…

d48ce6d

…adExitOffering Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

vegaro added pr:RevenueCatUI pr:other feat:PaywallV2 labels May 8, 2026

Merge branch 'main' into cesar/workflow-exit-offers

1b5a825

vegaro marked this pull request as ready for review May 8, 2026 10:28

vegaro requested a review from a team as a code owner May 8, 2026 10:28

Fix workflow exit offer dismissal gating

70ef624

cursor Bot reviewed May 8, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

Use property for workflow exit offer state

710cd90

facumenzella reviewed May 8, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

facumenzella reviewed May 8, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt

facumenzella reviewed May 8, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

facumenzella reviewed May 8, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

updateStateJob

b00772e

facumenzella mentioned this pull request May 8, 2026

Parse exit_offers field on WorkflowScreen RevenueCat/purchases-ios#6754

Merged

2 tasks

exitOfferData MutableStateFlow

56c8d7d

facumenzella reviewed May 8, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

vegaro added 3 commits May 8, 2026 14:41

move to workflow

03a51be

asume null singleStepFallbackId

bdd8fdf

better data classes

28ea7ff

cursor Bot reviewed May 8, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt

vegaro added 2 commits May 8, 2026 15:38

feedback

6a2f16f

simplify exit offre loading

27a0f0b

vegaro and others added 2 commits May 8, 2026 16:04

drop unused State wrapper from preloadedExitOffering

7a1aa48

Nothing observes it for recomposition. closePaywall reads it imperatively, so the MutableState/State machinery was pure overhead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Merge branch 'main' into cesar/workflow-exit-offers

b3cc1fc

facumenzella reviewed May 11, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

facumenzella reviewed May 11, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

vegaro added 2 commits May 11, 2026 09:32

Offerings non nullable

750bbb7

cancelAndResetState

63ba630

facumenzella reviewed May 11, 2026

View reviewed changes

facumenzella approved these changes May 11, 2026

View reviewed changes

added preloadRequested and preloadRequested properties

39829fc

cursor Bot reviewed May 11, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt Outdated

vegaro force-pushed the cesar/workflow-exit-offers branch from 597fa84 to d3cbb91 Compare May 11, 2026 10:25

cursor Bot reviewed May 11, 2026

View reviewed changes

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt

Comment thread ...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt

fix exception on awaitOfferings

070e138

vegaro added this pull request to the merge queue May 11, 2026

Merged via the queue into main with commit 1bf6078 May 11, 2026
36 checks passed

vegaro deleted the cesar/workflow-exit-offers branch May 11, 2026 12:03

RCGitBot mentioned this pull request May 13, 2026

[AUTOMATIC] Release/10.6.0 #3476

Merged

cursor Bot mentioned this pull request Jun 10, 2026

AGENTS.md and CODE_STYLE.md 2026 May update #3580

Draft

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add exit offers support to workflows#3452

Add exit offers support to workflows#3452
vegaro merged 23 commits into
mainfrom
cesar/workflow-exit-offers

vegaro commented May 7, 2026 •

edited by cursor Bot

Loading

Uh oh!

codecov Bot commented May 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facumenzella May 11, 2026

Uh oh!

vegaro May 11, 2026

Uh oh!

facumenzella left a comment

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vegaro commented May 7, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Fixes

Testing

Uh oh!

codecov Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facumenzella May 11, 2026

Choose a reason for hiding this comment

Uh oh!

vegaro May 11, 2026

Choose a reason for hiding this comment

Uh oh!

facumenzella left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vegaro commented May 7, 2026 •

edited by cursor Bot

Loading

codecov Bot commented May 8, 2026 •

edited

Loading