Extract PaywallComponentsImagePreDownloader#3448
Merged
Merged
Conversation
vegaro
commented
May 7, 2026
|
|
||
| private fun findImageUrisToDownload(paywallComponentsConfig: PaywallComponentsConfig): Set<Uri> { | ||
| return paywallComponentsConfig.stack.findImageUrisToDownload() + | ||
| (paywallComponentsConfig.header?.stack?.findImageUrisToDownload().orEmpty()) + |
Member
Author
There was a problem hiding this comment.
added header here, which we were missing
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3448 +/- ##
=======================================
Coverage 79.47% 79.47%
=======================================
Files 362 363 +1
Lines 14547 14560 +13
Branches 1977 1979 +2
=======================================
+ Hits 11561 11572 +11
Misses 2190 2190
- Partials 796 798 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
facumenzella
reviewed
May 7, 2026
| import com.revenuecat.purchases.paywalls.components.common.PaywallComponentsConfig | ||
| import com.revenuecat.purchases.paywalls.components.properties.ThemeImageUrls | ||
|
|
||
| internal class PaywallComponentsImagePreDownloader( |
facumenzella
reviewed
May 7, 2026
| } | ||
| } | ||
|
|
||
| private fun findImageUrisToDownload(paywallComponentsConfig: PaywallComponentsConfig): Set<Uri> { |
Member
There was a problem hiding this comment.
The traversal is still very ad hoc and shallow. In PaywallComponentsImagePreDownloader.kt, CarouselComponent only predownloads the carousel background, not images inside pages.
From my beloved agent 💅
You can take care of this in another PR
facumenzella
approved these changes
May 7, 2026
matteinn
pushed a commit
to matteinn/purchases-android
that referenced
this pull request
Jun 5, 2026
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * fix: url encode query prameters (RevenueCat#3451) via Jacob Rakidzich (@JZDesign) ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix: dismiss was called before onPurchaseComplete callback invocation (RevenueCat#3353) via Jacob Rakidzich (@JZDesign) * Propagate default package across workflow steps (RevenueCat#3431) via Cesar de la Vega (@vegaro) ### Paywallv2 #### ✨ New Features * feat: Allow disabling of automatic font scaling (RevenueCat#3438) via Jacob Rakidzich (@JZDesign) ### 🔄 Other Changes * Extract `PaywallComponentsImagePreDownloader` (RevenueCat#3448) via Cesar de la Vega (@vegaro) * Simplify `WorkflowTransitionState` with explicit from/to step fields (RevenueCat#3441) via Cesar de la Vega (@vegaro) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: primarily flips version strings from `10.5.0-SNAPSHOT` to `10.5.0` and updates docs/changelogs, with no functional code changes beyond the reported version constant. > > **Overview** > Cuts the `10.5.0` release by switching the project from `10.5.0-SNAPSHOT` to `10.5.0` across build metadata (`.version`, `gradle.properties`, sample/test app `libs.versions.toml`, and `Config.frameworkVersion`). > > Updates release artifacts and documentation pointers: CircleCI docs deploy now syncs the `10.5.0` docs folder to S3, `docs/index.html` redirects to `10.5.0`, and changelogs are rolled forward with the `10.5.0` entries in `CHANGELOG.md`/`CHANGELOG.latest.md`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 48537d6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #3447
Little refactor extracting PaywallComponentsImagePreDownloader
Note
Medium Risk
Changes paywall image predownload behavior and wiring, which could increase/alter network/cache usage for paywall assets (notably header images) and affect startup/background work.
Overview
Extracts Paywall V2 image predownload logic from
OfferingImagePreDownloaderinto a newPaywallComponentsImagePreDownloader, and updatesPurchasesFactoryto create/reuse a singleCoilImageDownloaderand pass the new predownloader through.Updates the image selection for Paywall V2 to include
headerstack assets (in addition to stack/sticky footer/background), and adjusts tests to cover the new header image/icon downloads.Reviewed by Cursor Bugbot for commit 2bb8a6e. Bugbot is set up for automated code reviews on this repo. Configure here.