Fix paywall layout direction for RTL locale overrides (PWENG-39)#3425
Merged
Conversation
JayShortway
approved these changes
May 1, 2026
| ) { | ||
| ComponentView( | ||
| style = state.stack, | ||
| CompositionLocalProvider(LocalLayoutDirection provides state.locale.toJavaLocale().toLayoutDirection()) { |
Member
There was a problem hiding this comment.
This is probably fine, but at the risk of premature optimization: we could remember the layout direction, to avoid creating a new Configuration object on every recomposition. Something like:
val layoutDirection = remember(state.locale) { state.locale.toJavaLocale().toLayoutDirection() }
CompositionLocalProvider(LocalLayoutDirection provides layoutDirection) {Again, feel free to ignore.
Member
Author
There was a problem hiding this comment.
That's a great recommendation, will apply it, thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3425 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 362 362
Lines 14539 14539
Branches 1976 1976
=======================================
Hits 11552 11552
Misses 2190 2190
Partials 797 797 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JayShortway
approved these changes
May 1, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 19, 2026
### Motivation After #3425 was merged, the affected customer identified layout bugs in RTL mode. This PR fixes the main one reported (timeline), as well as other quick-win ones. ### Description - Fixes timeline text constraints in RTL so text starts from the correct edge without overlapping the icon. - Makes workflow slide transitions respect RTL layout direction. - Replaces remaining physical custom-layout placement calls with `placeRelative`. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are limited to Compose layout/constraint behavior and transition direction math, primarily affecting RTL rendering and slide animations. > > **Overview** > Fixes several RTL rendering issues in paywall UI. > > Workflow step slide animations now account for `LayoutDirection` so horizontal transitions reverse correctly in RTL, and call sites pass the current layout direction into `workflowTransition`. > > Custom `Modifier.layout` usages were updated to use `placeRelative` (instead of physical `place`) for header overlay and top-padding helpers, and timeline constraints were rewritten to use `linkTo(...)` (removing end-barrier usage) so title/description text aligns from the correct edge without overlapping icons in RTL. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 9710048. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
matteinn
pushed a commit
to matteinn/purchases-android
that referenced
this pull request
Jun 5, 2026
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add optional support for setting obfuscated account id to product changes (RevenueCat#3428) via Mark Villacampa (@MarkVillacampa) ## RevenueCatUI SDK ### Paywallv2 #### ✨ New Features * Add slide transition to workflow paywalls (RevenueCat#3418) via Cesar de la Vega (@vegaro) * Workflow state & ViewModel infrastructure (RevenueCat#3416) via Cesar de la Vega (@vegaro) #### 🐞 Bugfixes * Fix paywall layout direction for RTL locale overrides (PWENG-39) (RevenueCat#3425) via Monika Mateska (@MonikaMateska) * Apply ripple shape clip on a sibling Box to avoid clipping content (RevenueCat#3395) via Toni Rico (@tonidero) ### 🔄 Other Changes * build(deps): bump fastlane-plugin-revenuecat_internal from `21e02ec` to `af7bb5c` (RevenueCat#3442) via dependabot[bot] (@dependabot[bot]) * Abstract workflow page transition animation behind sealed class (RevenueCat#3430) via Cesar de la Vega (@vegaro) * Add `single_step_fallback_id` field to `PublishedWorkflow` (RevenueCat#3436) via Cesar de la Vega (@vegaro) * build(deps): bump fastlane-plugin-revenuecat_internal from `2d11430` to `21e02ec` (RevenueCat#3429) via dependabot[bot] (@dependabot[bot]) * Generalize `PaywallComponentsScaffold` for workflow reuse (RevenueCat#3417) via Cesar de la Vega (@vegaro) * perf: pre-warm workflow paywall step states off-thread (RevenueCat#3420) via Cesar de la Vega (@vegaro) * Update baseline profiles (RevenueCat#3427) via RevenueCat Git Bot (@RCGitBot) * build(deps): bump fastlane-plugin-revenuecat_internal from `d24ab26` to `2d11430` (RevenueCat#3426) via dependabot[bot] (@dependabot[bot]) * Replace unauthenticated SDKMAN install with SHA-pinned orb command (RevenueCat#3407) via Rick (@rickvdl) * Auto load paywall in paywall tester via local.properties (RevenueCat#3405) via Cesar de la Vega (@vegaro) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this is a version/release cut that mainly updates version strings, changelogs, and doc deployment targets with no functional logic changes beyond version identifiers. > > **Overview** > Cuts the `10.4.0` release by removing `-SNAPSHOT` across the project (core `VERSION_NAME`, `Config.frameworkVersion`, sample/test app dependency versions, and the root `.version` file). > > Updates release collateral and publishing to point at `10.4.0`, including changelogs (`CHANGELOG.md`/`CHANGELOG.latest.md`), docs redirect (`docs/index.html`), and the CircleCI `docs-deploy` S3 sync path (from `10.4.0-SNAPSHOT` to `10.4.0`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit f7b3604. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybrids PRMotivation
Fixes paywall layout direction when
preferredUILocaleOverrideresolves to an RTL locale while the device/system locale is LTR.Previously, Android paywalls could use the overridden locale for localized strings while still inheriting the system Compose
LocalLayoutDirection, so RTL languages like Hebrew and Arabic could render translated text but keep LTR layout behavior.Resolves: PWENG-39
Changes
Configuration.layoutDirection.Screen_recording_20260501_134422.webm
Note
Medium Risk
Changes paywall composition locals to force
LocalLayoutDirectionbased on the resolved/overridden locale, which could subtly affect layout/alignment across both legacy and components paywalls. Risk is limited to UI rendering (no purchase/auth logic), but may introduce visual regressions in LTR/RTL edge cases.Overview
Fixes paywall rendering when a
preferredUILocaleOverrideresolves to an RTL language by deriving a ComposeLayoutDirectionfrom the resolved locale and providing it viaLocalLayoutDirection.Applies this override in both legacy template paywalls (
InternalPaywall) and V2/components paywalls (LoadedPaywallComponents), and adds a newLocale.toLayoutDirection()helper with Android instrumentation tests covering RTL (Hebrew/Arabic/Farsi) and LTR locales.Reviewed by Cursor Bugbot for commit 8fc3352. Bugbot is set up for automated code reviews on this repo. Configure here.