Skip to content

Extract private function NavigateTo.toPaywallAction#3392

Merged
vegaro merged 1 commit into
mainfrom
cesar/refactor-toPaywallAction
Apr 27, 2026
Merged

Extract private function NavigateTo.toPaywallAction#3392
vegaro merged 1 commit into
mainfrom
cesar/refactor-toPaywallAction

Conversation

@vegaro

@vegaro vegaro commented Apr 27, 2026

Copy link
Copy Markdown
Member

Groundwork for #3381 to keep the review simpler.

I am just extracting a private function


Note

Low Risk
Low risk refactor that only reorganizes NavigateTo action mapping logic without changing behavior. Main risk is accidental regression in NavigateTo destination handling, but the moved code remains identical.

Overview
Refactors ButtonComponentState by extracting the ButtonComponentStyle.Action.NavigateToPaywallAction conversion into a dedicated private NavigateTo.toPaywallAction(localeId) helper.

The main Action.toPaywallAction mapping now delegates NavigateTo handling to this helper, keeping behavior (including locale-specific URL selection) unchanged.

Reviewed by Cursor Bugbot for commit 8d7dbb1. Bugbot is set up for automated code reviews on this repo. Configure here.

@vegaro vegaro force-pushed the cesar/refactor-toPaywallAction branch from c4f6e83 to 8d7dbb1 Compare April 27, 2026 12:14

@facumenzella facumenzella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.36%. Comparing base (17c63da) to head (8d7dbb1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3392   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files         361      361           
  Lines       14458    14458           
  Branches     1964     1964           
=======================================
  Hits        11475    11475           
  Misses       2190     2190           
  Partials      793      793           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vegaro vegaro added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit 197b6f3 Apr 27, 2026
38 checks passed
@vegaro vegaro deleted the cesar/refactor-toPaywallAction branch April 27, 2026 13:24
matteinn pushed a commit to matteinn/purchases-android that referenced this pull request May 5, 2026
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Unified StoreReplacementMode API (RevenueCat#3234) via Will Taylor
(@fire-at-will)
* Add placement and targeting context to paywall events (RevenueCat#3253) via Dan
Pannasch (@dpannasch)
### 🐞 Bugfixes
* Fix null Placements when offering_ids_by_placement is absent (RevenueCat#3254)
via Dan Pannasch (@dpannasch)

## RevenueCatUI SDK
### Paywallv2
#### ✨ New Features
* Wire multipage workflow navigation into PaywallViewModel (RevenueCat#3381) via
Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* Add `triggerType` to `WorkflowTrigger` (RevenueCat#3393) via Cesar de la Vega
(@vegaro)
* Extract private function `NavigateTo.toPaywallAction` (RevenueCat#3392) via
Cesar de la Vega (@vegaro)
* Bump revenucatui-tests gradle cache key (RevenueCat#3391) via Toni Rico
(@tonidero)
* Create `WorkflowTriggerType` and `WorkflowTriggerActionType` (RevenueCat#3386)
via Cesar de la Vega (@vegaro)
* Update baseline profiles (RevenueCat#3390) via RevenueCat Git Bot (@RCGitBot)
* Plumb `componentId` through buttons on workflow interactions (RevenueCat#3380)
via Cesar de la Vega (@vegaro)
* Add `ButtonComponent.Action.Workflow` (RevenueCat#3385) via Cesar de la Vega
(@vegaro)
* Add `componentId` to `ButtonCoomponentStyle` (RevenueCat#3384) via Cesar de la
Vega (@vegaro)
* Migrate all suspendCoroutine usages to suspendCancellableCoroutine
(RevenueCat#3365) via Jaewoong Eum (@skydoves)
* Add `WorkflowNavigator` for multipage workflow step navigation (RevenueCat#3379)
via Cesar de la Vega (@vegaro)
* build(deps): bump fastlane-plugin-revenuecat_internal from `b822f01`
to `d24ab26` (RevenueCat#3383) via dependabot[bot] (@dependabot[bot])
* Add `id` field to `ButtonComponent` (RevenueCat#3377) via Cesar de la Vega
(@vegaro)
* Add CI workflows for generating Baseline Profiles (RevenueCat#3372) via Jaewoong
Eum (@skydoves)
* add min sdk level for paywalls and customer center (RevenueCat#2465) via
Muhammad-Sharif Moustafa (@mshmoustafa)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk release bookkeeping: updates version strings, changelogs, and
documentation deployment targets without changing runtime logic beyond
the reported version identifier.
> 
> **Overview**
> Cuts the `10.3.0` release by updating all version references from
`10.3.0-SNAPSHOT` to `10.3.0` across build config (`gradle.properties`,
`.version`, `Config.frameworkVersion`) and sample/test app dependency
pins.
> 
> Updates release documentation publishing to sync Dokka output to the
`10.3.0` S3 path and changes `docs/index.html` to redirect to `10.3.0`.
Also promotes release notes by moving `CHANGELOG.latest.md` entries into
a new `CHANGELOG.md` section for `10.3.0`.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
056ce62. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants