ci: warn when pre-built material-icons are imported in :ui:revenuecatui#3282
Merged
facumenzella merged 6 commits intoMar 26, 2026
Merged
Conversation
The module avoids the material-icons runtime dependency by using custom inline icon vectors. Importing Icons.Filled.* etc. causes NoClassDefFoundError at runtime in apps that don't bundle the artifact. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
JZDesign
approved these changes
Mar 26, 2026
tonidero
approved these changes
Mar 26, 2026
tonidero
left a comment
Contributor
There was a problem hiding this comment.
This makes a lot of sense. Thanks for adding this!!
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r CI) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tives on comments Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
=======================================
Coverage 79.38% 79.38%
=======================================
Files 357 357
Lines 14349 14349
Branches 1960 1960
=======================================
Hits 11391 11391
Misses 2154 2154
Partials 804 804 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Use Amazon deep link for Amazon subscription management (#3291) via Cesar de la Vega (@vegaro) * Introduce purchases codegen package (#3163) via Jaewoong Eum (@skydoves) ### 🐞 Bugfixes * Fix Test Store Purchase dialog not cancelling purchase on outside tap (#3289) via Antonio Pallares (@ajpallares) ## RevenueCatUI SDK ### Paywallv2 #### 🐞 Bugfixes * Fix mixed currencies in paywall price variables (PW-133) (#3119) via Facundo Menzella (@facumenzella) ### 🔄 Other Changes * Add docs for the codegen plugin (#3288) via Jaewoong Eum (@skydoves) * Run integration tests against all backend environments (#3278) via Toni Rico (@tonidero) * Use merge queue for release PR merging (#3281) via Antonio Pallares (@ajpallares) * ci: warn when pre-built material-icons are imported in :ui:revenuecatui (#3282) via Facundo Menzella (@facumenzella) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this is a version/release bookkeeping update plus docs/CI deployment path changes, with no functional runtime logic changes beyond the reported version string. > > **Overview** > Cuts the `9.29.0` release by switching all references from `9.29.0-SNAPSHOT` to `9.29.0` (Gradle `VERSION_NAME`, internal `frameworkVersion`, and sample/test app dependency versions). > > Updates documentation publishing to point to the `9.29.0` docs directory (CircleCI S3 sync path and `docs/index.html` redirect), and rolls forward `CHANGELOG.md`/`CHANGELOG.latest.md` with the 9.29.0 release notes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bf217fd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
material-iconsimport in:ui:revenuecatui(anything fromandroidx.compose.material.icons.*exceptmaterialIcon/materialPath)material-iconsruntime dependency by defining custom inline icon vectors — usingIcons.Filled.*etc. causesNoClassDefFoundErrorat runtime in apps that don't bundle the artifact (seeDefaultProductCell.ktintroduced in Feature: Update default paywall #3133)Test plan
import androidx.compose.material.icons.Iconsto a file underui/revenuecatui/import androidx.compose.material.icons.materialIcon/materialPathNote
Low Risk
Low risk CI-only change that adds a warning rule; it doesn’t affect runtime behavior, but could introduce noisy/false-positive PR warnings if the regex misses edge cases.
Overview
Adds a new Danger rule that scans added/modified
ui/revenuecatui/*.ktdiffs and emits a warning when a PR introduces directandroidx.compose.material.icons.*imports (exceptmaterialIcon/materialPath).This enforces the module’s intent to avoid a
material-iconsruntime dependency by steering contributors toward custom inline icons undericons/.Written by Cursor Bugbot for commit e819ec9. This will update automatically on new commits. Configure here.