Update to Billing Library 8.3.0#3256
Conversation
33a4cb8 to
67c238e
Compare
…3257) This PR automatically updates the golden test files in `purchases/src/test/resources/backend_integration_tests_golden/` based on the latest backend integration test results. Generated from branch: `update-billing-client-8-3-0` Please review the changes to ensure they are expected. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: updates are limited to backend integration test golden JSON fixtures and do not change production code paths. > > **Overview** > Updates the backend integration test golden request fixtures under `purchases/src/test/resources/backend_integration_tests_golden/` to expect `X-Billing-Client-Sdk-Version: 8.3.0` (from `8.0.0`) across offerings, product entitlement mapping, login, events, and virtual currencies request snapshots. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit fbda4ee. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
=======================================
Coverage 79.48% 79.48%
=======================================
Files 357 357
Lines 14352 14352
Branches 1960 1960
=======================================
Hits 11407 11407
Misses 2141 2141
Partials 804 804 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a07cf54. Configure here.
| "headers": { | ||
| "Content-Type": "application\/json", | ||
| "X-Billing-Client-Sdk-Version": "8.0.0", | ||
| "X-Billing-Client-Sdk-Version": "8.3.0", |
There was a problem hiding this comment.
Golden test files appear manually edited
Low Severity
All golden test JSON files in this PR have only a single value changed (X-Billing-Client-Sdk-Version from 8.0.0 to 8.3.0), which matches the pattern of a manual find-and-replace edit rather than regeneration by running the backend integration test suite. Per project rules, these files need to be regenerated by running the tests to avoid subtle issues like missing trailing newlines or incorrect headers.
Additional Locations (2)
- [
purchases/src/test/resources/backend_integration_tests_golden/FallbackURLBackendIntegrationTest/can perform offerings backend request/request_001.json#L5-L6](https://github.com/RevenueCat/purchases-android/blob/a07cf54299ff24d0d57aaa16f1b13aeee9fc1391/purchases/src/test/resources/backend_integration_tests_golden/FallbackURLBackendIntegrationTest/can perform offerings backend request/request_001.json#L5-L6) - [
purchases/src/test/resources/backend_integration_tests_golden/LoadShedderUSEast1BackendIntegrationTest/can perform offerings backend request/request_001.json#L5-L6](https://github.com/RevenueCat/purchases-android/blob/a07cf54299ff24d0d57aaa16f1b13aeee9fc1391/purchases/src/test/resources/backend_integration_tests_golden/LoadShedderUSEast1BackendIntegrationTest/can perform offerings backend request/request_001.json#L5-L6)
Triggered by learned rule: Golden test files must be regenerated by running tests, not manually edited
Reviewed by Cursor Bugbot for commit a07cf54. Configure here.
## RevenueCat SDK > [!WARNING] > If you don't have any login system in your app, please make sure your one-time purchase products have been correctly configured in the RevenueCat dashboard as either consumable or non-consumable. If they're incorr as consumables, RevenueCat will consume these purchases. This means that users won't be able to restore them from version 10.0.0 onward. > Non-consumables are products that are meant to be bought only once, for example, lifetime subscriptions. Please see more information in our [docs](https://www.revenuecat.com/docs/known-store-issues/play-billing-library/restore-consumable-purchases-bc8) ### 💥 Breaking Changes This release updates to Billing Library 8.3.0 with min SDK supported of Android 6 (API 23), previously min was 21. It also removes a previous workaround used to be able to restore consumed one time products which is not available anymore. * Update to Billing Library 8.3.0 (#3256) via Toni Rico (@tonidero) * Revert AIDL workaround for consumed consumables (#3255) via Toni Rico (@tonidero) ### 🔄 Other Changes * Bump fastlane-plugin-revenuecat_internal from `6289be1` to `ceecf91` (#3301) via dependabot[bot] (@dependabot[bot]) * Increase targetSdkVersion to 36 (#2446) via Toni Rico (@tonidero) * [AUTOMATIC] Update golden test files for backend integration tests (#3302) via RevenueCat Git Bot (@RCGitBot) * Bump fastlane-plugin-revenuecat_internal from `5d6e93f` to `6289be1` (#3299) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `f11fe40` to `5d6e93f` (#3294) via dependabot[bot] (@dependabot[bot]) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Primarily a release/version bump, but it ships documented breaking changes (minSdk 23 via Billing Library 8.3.0 and removal of a restore workaround) that can affect app compatibility and restore behavior. > > **Overview** > Bumps the project from `9.30.0-SNAPSHOT` to `10.0.0` across build metadata (`.version`, `gradle.properties`, `Config.frameworkVersion`) and sample/test app dependency pins. > > Updates release documentation: adds `10.0.0` entries to `CHANGELOG.md`/`CHANGELOG.latest.md` (including a warning and breaking-change notes) and introduces `migrations/v10-MIGRATION.md`. > > Adjusts docs publishing to serve `10.0.0` by updating `docs/index.html` redirect and the CircleCI S3 sync path in `docs-deploy`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d18f479. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->


Description
This updates to Billing Library 8.3.0, which includes a breaking change in the minSdk version that was bumped from 21 to 23.
Note
Medium Risk
Medium risk because it raises the project-wide
minSdkfrom 21 to 23 (dropping Android 5.x support) and updates Google Play Billing Client to 8.3.0, which can impact purchase flows and test infrastructure.Overview
Updates Google Play Billing Client
bc8from8.0.0to8.3.0via the version catalog, and refreshes backend integration test golden request headers to match the new billing client version.Raises the effective minimum supported Android version across the repo from API 21 to API 23, updating sample apps, test apps, the
integration-testsmodule,ui:debugview, Fastlane test lanes, and documentation (README.md,AGENTS.md) to align with the new requirement.Reviewed by Cursor Bugbot for commit a07cf54. Bugbot is set up for automated code reviews on this repo. Configure here.