Fix & Standardize Galaxy Date Parsing Edge Cases by fire-at-will · Pull Request #3216 · RevenueCat/purchases-android

fire-at-will · 2026-03-11T17:22:34Z

Description

Cursor pointed out that if subscription end date parsing fails, an exception is thrown and finish() is never called, which can halt execution. This PR fixes that by handling subscription end date parsing failures gracefully and ignoring the affected product instead of failing the whole flow.

Additionally, this PR updates the .toStoreTransaction() calls in queryPurchases() and queryAllPurchases() so that individual parsing failures cause only the affected transaction to be skipped, while successfully parsed transactions are still returned. The methods now fail only if parsing fails for all transactions.

This matches the existing partial-failure behavior used by the Amazon implementation of queryPurchases() and queryAllPurchases().

Note

Medium Risk
Changes purchase restore/query behavior to skip malformed Galaxy owned products and only error when all transactions are invalid, which could affect edge-case restore results. Also adds new date-parse error handling to avoid stalled serial execution on parsing exceptions.

Overview
Hardens Galaxy purchase restore/query flows against malformed store data. queryAllPurchases and queryPurchases now use mapNotNull to skip individual owned products that fail toStoreTransaction() parsing, and only return InvalidReceiptError when the owned list is non-empty but no valid transactions could be parsed.

queryPurchases additionally guards subscriptionEndDate.parseDateFromGalaxyDateString() with a try/catch, logging and filtering out entries with invalid end dates so serial execution always completes. New standardized strings were added for transaction and subscription-end-date parsing errors, and tests were updated/added to cover partial-failure filtering and the all-invalid error case.

^{Written by Cursor Bugbot for commit 6c69286. This will update automatically on new commits. Configure here.}

…venueCat/purchases-android into galaxy/fix-date-parsing-issue

codecov · 2026-03-11T17:55:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.41%. Comparing base (9768055) to head (6c69286).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3216   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files         356      356           
  Lines       14342    14342           
  Branches     1958     1958           
=======================================
  Hits        11389    11389           
  Misses       2149     2149           
  Partials      804      804

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tonidero

This PR might be missing a part? Lmk if I'm missing something though! In any case, I think the changes in this PR make sense!

tonidero · 2026-03-12T08:37:19Z

 import java.util.Locale
 import java.util.TimeZone

+@Throws(IllegalArgumentException::class)


Unfortunately kotlin doesn't force callers to handle exceptions :( But I think it's better to add it 👍

Agreed - better to have it than not!

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

fire-at-will · 2026-03-13T15:47:10Z

@tonidero Good callout on the finally block. I've removed it from the description. I decided not to use the finally pattern because if the onSuccess() callback threw any exception for any reason, the exception would be caught, and then the onError() callback would be executed, which would cause the function's onSuccess() and onError() callbacks to be executed, which definitely isn't the intended behavior.

I've also updated the parsing code in both queryPurchases() and queryAllPurchases() so that when parsing a transaction to a StoreTransaction fails, we log an error and then gracefully ignore that transaction when we return the results. We only error out if the parsing for all transactions fail. This mirrors the pattern used by the Amazon store.

Let me know what you think!

tonidero

Makes sense!

@fire-at-will

**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Fix & Standardize Galaxy Date Parsing Edge Cases (#3216) via Will Taylor (@fire-at-will) * Fix addSuccessfullyPostedToken for new purchases in PostPendingTransactionsHelper (#3239) via Facundo Menzella (@facumenzella) * [Galaxy]: Fix race condition when fetching Galaxy products (#3213) via Will Taylor (@fire-at-will) * Fixes double padding in PaywallActivity on Android 15+ when `edgeToEdge` parameter is false (#3227) via Cesar de la Vega (@vegaro) ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix bold text not rendering in Markdown lists (#3228) via Cesar de la Vega (@vegaro) * Fix: Clear in-memory offerings cache on locale override to prevent stale paywall data (#3225) via Antonio Pallares (@ajpallares) ### Paywallv2 #### ✨ New Features * Feature: Update default paywall (#3133) via Jacob Rakidzich (@JZDesign) #### 🐞 Bugfixes * Fix V2 paywall safe area in landscape mode (#3221) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Run integration tests on all branches (#3242) via Toni Rico (@tonidero) * Migrate Firebase Test Lab jobs to CircleCI emulators (#3238) via Toni Rico (@tonidero) * Run metalava on galaxy module in test-galaxy job (#3235) via Will Taylor (@fire-at-will) * Add offering_id to custom paywall impression event (#3230) via Rick (@rickvdl) * Cache isAutoRenewing to detect subscription changes without syncPurchases (#3198) via Facundo Menzella (@facumenzella) * Bump fastlane-plugin-revenuecat_internal from `e146447` to `3e8c384` (#3233) via dependabot[bot] (@dependabot[bot])  --- > [!NOTE] > **Low Risk** > Low risk release housekeeping: version string bumps and documentation/deployment path updates with no functional runtime logic changes beyond the exposed version constant. > > **Overview** > Publishes the `9.26.0` release by removing `-SNAPSHOT` across build/version metadata (root `VERSION_NAME`, `.version`, `Config.frameworkVersion`, and sample/test app dependency pins). > > Updates release documentation artifacts by adding the `9.26.0` notes to `CHANGELOG.md`/`CHANGELOG.latest.md`, switching docs deployment in CircleCI to sync `docs/9.26.0` to S3, and updating `docs/index.html` to redirect to the new version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0a30a45. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

fire-at-will added 3 commits March 11, 2026 12:11

handle date parsing issue

5b8db2c

call finish() in a finally block

7b1afa7

re-add comment

e417d26

fire-at-will requested a review from a team as a code owner March 11, 2026 17:22

Merge branch 'main' into galaxy/fix-date-parsing-issue

0f7f69d

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread feature/galaxy/src/main/kotlin/com/revenuecat/purchases/galaxy/GalaxyBillingWrapper.kt

Comment thread feature/galaxy/src/test/java/com/revenuecat/purchases/galaxy/GalaxyBillingWrapperTest.kt Outdated

fire-at-will added the pr:fix A bug fix label Mar 11, 2026

fire-at-will added 2 commits March 11, 2026 12:30

ignore product

cb4d3c8

Merge branch 'galaxy/fix-date-parsing-issue' of https://github.com/Re…

45223ee

…venueCat/purchases-android into galaxy/fix-date-parsing-issue

RevenueCat deleted a comment from RevenueCat-Danger-Bot Mar 11, 2026

use activeSubscriptionEndDate that is always in the future

94bc1dc

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread feature/galaxy/src/main/kotlin/com/revenuecat/purchases/galaxy/GalaxyBillingWrapper.kt Outdated

remove the finally

2beb85e

tonidero approved these changes Mar 12, 2026

View reviewed changes

consistent date parse error handling

ea159fa

cursor Bot reviewed Mar 13, 2026

View reviewed changes

Comment thread feature/galaxy/src/main/kotlin/com/revenuecat/purchases/galaxy/GalaxyStrings.kt Outdated

fire-at-will added 2 commits March 13, 2026 10:00

fix error message

3ca54fb

Merge branch 'main' into galaxy/fix-date-parsing-issue

e991b77

fire-at-will changed the title ~~Fix Galaxy date parsing issue when fetching purchases~~ Fix & Standardize Galaxy Date Parsing Edge Cases Mar 13, 2026

fire-at-will requested a review from tonidero March 13, 2026 15:47

Merge branch 'main' into galaxy/fix-date-parsing-issue

6c69286

tonidero approved these changes Mar 16, 2026

View reviewed changes

fire-at-will added this pull request to the merge queue Mar 16, 2026

Merged via the queue into main with commit 57ac08c Mar 16, 2026
30 checks passed

fire-at-will deleted the galaxy/fix-date-parsing-issue branch March 16, 2026 15:58

RCGitBot mentioned this pull request Mar 16, 2026

[AUTOMATIC] Release/9.26.0 #3244

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix & Standardize Galaxy Date Parsing Edge Cases#3216

Fix & Standardize Galaxy Date Parsing Edge Cases#3216
fire-at-will merged 12 commits into
mainfrom
galaxy/fix-date-parsing-issue

fire-at-will commented Mar 11, 2026 •

edited by cursor Bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

tonidero left a comment

Uh oh!

Uh oh!

tonidero Mar 12, 2026

Uh oh!

fire-at-will Mar 13, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

fire-at-will commented Mar 13, 2026

Uh oh!

tonidero left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fire-at-will commented Mar 11, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tonidero Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

fire-at-will Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fire-at-will commented Mar 13, 2026

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fire-at-will commented Mar 11, 2026 •

edited by cursor Bot

Loading

codecov Bot commented Mar 11, 2026 •

edited

Loading