[Conditional Configurability][3] Implement variable, selected package, and extended intro/promo condition evaluation#3112
Merged
vegaro merged 1 commit intoFeb 18, 2026
Conversation
56b5031 to
8fa05ed
Compare
e8dc666 to
d22d929
Compare
d22d929 to
f2ca67e
Compare
8fa05ed to
3607d07
Compare
3607d07 to
903b0ec
Compare
f2ca67e to
5f6bebb
Compare
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5f6bebb to
1327aba
Compare
903b0ec to
48cd554
Compare
6 tasks
facumenzella
left a comment
Member
There was a problem hiding this comment.
See inline comment below
1327aba to
03f2bd3
Compare
88e257e to
2020bc1
Compare
03f2bd3 to
68d0698
Compare
Base automatically changed from
cesar/pw-170-selected-package-condition-evaluation
to
cesar/conditional-configurability
February 18, 2026 15:35
082e975 to
72b2a6b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cesar/conditional-configurability #3112 +/- ##
==================================================================
Coverage 79.22% 79.22%
==================================================================
Files 347 347
Lines 13948 13948
Branches 1893 1893
==================================================================
Hits 11050 11050
Misses 2112 2112
Partials 786 786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ation - Introduce ConditionContext to group all condition evaluation parameters - Implement Variable condition: compare custom variables by type and value - Implement Package condition: compare against enclosing PackageComponent ID - Implement extended IntroOffer/PromoOffer: evaluate with operator and value (legacy no-operator form defaults to equals/true for backwards compat) - Thread customVariablesProvider through all component states - Add mergedCustomVariables to PaywallState (developer overrides dashboard) - Add comprehensive tests for all new condition evaluation paths Co-authored-by: Cursor <cursoragent@cursor.com>
72b2a6b to
1d0e5b1
Compare
facumenzella
approved these changes
Feb 18, 2026
25 of 28 checks passed
vegaro
added a commit
that referenced
this pull request
Feb 19, 2026
…, and extended intro/promo condition evaluation (#3112) ### Motivation Completes the V0 condition evaluation logic. - With variable conditions paywalls can adapt based on developer custom variables. - Selected package conditions let components change based on which package the user has selected. - Intro/promo conditions now support explicit operator (`=`/`!=`) and value fields for more precise control. ### Description - Implements `Variable` condition evaluation with equality comparison and type coercion (string, bool, int, double) - Implements `SelectedPackage` condition evaluation against the currently selected package ID - Implements extended `IntroOffer` and `PromoOffer` evaluation with `operator` (`=`/`!=`) and `value` fields - Removes `Package` condition (not used by backend or dashboard) - Threads `customVariables` through `ConditionContext` to all component state classes - Wires `customVariables` from `PaywallState.Loaded` into the evaluation pipeline Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Completes the V0 condition evaluation logic.
=/!=) and value fields for more precise control.Description
Variablecondition evaluation with equality comparison and type coercion (string, bool, int, double)SelectedPackagecondition evaluation against the currently selected package IDIntroOfferandPromoOfferevaluation withoperator(=/!=) andvaluefieldsPackagecondition (not used by backend or dashboard)customVariablesthroughConditionContextto all component state classescustomVariablesfromPaywallState.Loadedinto the evaluation pipeline