Fix purchase callback not firing for DEFERRED product changes with baePlanId in oldProductId#2937
Merged
tonidero merged 1 commit intoDec 16, 2025
Conversation
…sePlanId in oldProductId
tonidero
approved these changes
Dec 16, 2025
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Amazing! Makes sense, and thanks for the fix!!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2937 +/- ##
=======================================
Coverage 78.82% 78.82%
=======================================
Files 337 337
Lines 13126 13129 +3
Branches 1770 1771 +1
=======================================
+ Hits 10346 10349 +3
Misses 2038 2038
Partials 742 742 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 17, 2025
tonidero
added a commit
that referenced
this pull request
Dec 18, 2025
## RevenueCat SDK ### ✨ New Features * Adds `setAppsFlyerConversionData` to conveniently track AppsFlyer conversion data (#2931) via JayShortway (@JayShortway) ### 🐞 Bugfixes * Make close() method also clear the shared instance of the SDK (#2940) via Toni Rico (@tonidero) * Fix purchase callback not firing for DEFERRED product changes with baePlanId in oldProductId (#2937) via Facundo Menzella (@facumenzella) ### 🔄 Other Changes * [AUTOMATIC] Update golden test files for backend integration tests (#2949) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC] Update golden test files for backend integration tests (#2944) via RevenueCat Git Bot (@RCGitBot) * Adds `.kotlin` to `.gitignore` (#2941) via JayShortway (@JayShortway) * Dont use reflection to instantiate AmazonOfferingParser (#2934) via Will Taylor (@fire-at-will) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes an issue where the purchase callback would never fire when performing a product change using
GoogleReplacementMode.DEFERREDif theoldProductIdcontained a base plan ID suffix (e.g.,"productId:basePlanId").Addresses #2874
Description
Root Cause
When using DEFERRED proration mode:
oldProductId(which could include:basePlanId)"productId"≠"productId:basePlanId"