Skip to content

Handle Unsupported BillingWrapper Functions on the GalaxyBillingWrapper#2906

Merged
fire-at-will merged 3 commits into
samsung-devfrom
error-on-galaxy-storefront
Dec 9, 2025
Merged

Handle Unsupported BillingWrapper Functions on the GalaxyBillingWrapper#2906
fire-at-will merged 3 commits into
samsung-devfrom
error-on-galaxy-storefront

Conversation

@fire-at-will

@fire-at-will fire-at-will commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Description

The Galaxy Store doesn't support fetching the current storefront/country code or showing in-app messages, so this PR:

  • Logs + throws an error when GalaxyBillingWrapper.getStorefront() is called
  • Adds docs explaining that the storefront functions/properties aren't supported for the Galaxy Store
  • Adds a comment to GalaxyBillingWrapper to explicitly call out that in-app messages aren't supported

@fire-at-will fire-at-will added the pr:feat A new feature label Dec 8, 2025
@fire-at-will fire-at-will marked this pull request as ready for review December 8, 2025 20:56
@fire-at-will fire-at-will requested a review from a team as a code owner December 8, 2025 20:56
@fire-at-will

fire-at-will commented Dec 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

A good number of the CI jobs are failing due to some compilation issues in the tests...this is because I based my branch off of #2905 at first, and then when it was time to create my PR, I forked the branch for this PR directly off of samsung-dev instead so the PR's diff would only show the net new changes in these commits.

Once #2905 is approved, I'll merge it into samsung-dev, and merge samsung-dev into this branch, and all will be well :)

tonidero
tonidero approved these changes Dec 9, 2025
View reviewed changes

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@codecov

codecov Bot commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.38%. Comparing base (85ef92c) to head (4844e46).
⚠️ Report is 1 commits behind head on samsung-dev.

Files with missing lines Patch % Lines
...tlin/com/revenuecat/purchases/common/logWrapper.kt 75.00% 1 Missing ⚠️
...n/com/revenuecat/purchases/galaxy/GalaxyStrings.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           samsung-dev    #2906   +/-   ##
============================================
  Coverage        78.37%   78.38%           
============================================
  Files              336      337    +1     
  Lines            12952    12961    +9     
  Branches          1752     1752           
============================================
+ Hits             10151    10159    +8     
- Misses            2065     2066    +1     
  Partials           736      736

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fire-at-will fire-at-will merged commit dfc862b into samsung-dev Dec 9, 2025
23 checks passed
@fire-at-will fire-at-will deleted the error-on-galaxy-storefront branch December 9, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonidero tonidero tonidero approved these changes

@MarkVillacampa MarkVillacampa Awaiting requested review from MarkVillacampa

Assignees

No one assigned

Labels

pr:feat A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fire-at-will @tonidero