Support Configuring the SDK with the Galaxy Store#2905
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## samsung-dev #2905 +/- ##
============================================
Coverage 78.36% 78.37%
============================================
Files 335 336 +1
Lines 12931 12952 +21
Branches 1751 1752 +1
============================================
+ Hits 10134 10151 +17
- Misses 2062 2065 +3
- Partials 735 736 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonidero
left a comment
There was a problem hiding this comment.
Looking nice! Just some questions
| @@ -0,0 +1,4 @@ | |||
| -dontwarn com.samsung.** | |||
| -keep class com.samsung.** {*;} | |||
There was a problem hiding this comment.
Just to check, are these rules recommended by samsung? Since this basically keeps everything which is not a great practice (though we also need to clean this up 😅 )
There was a problem hiding this comment.
I haven't seen this recommended by samsung - I copied this over directly from our Amazon module and replaced amazon with samsung. Do you think we should remove this?
There was a problem hiding this comment.
Unless we have a reason to disable obfuscated of those classes, I would say yes, let's remove this 👍
| * Holds parameters to initialize the SDK for the Galaxy Store. Create an instance of this class using the [Builder] | ||
| * and pass it to [Purchases.configure]. | ||
| */ | ||
| public final class GalaxyConfiguration extends PurchasesConfiguration { |
There was a problem hiding this comment.
Should we add API tests for this as well? Alternatively, we could mark these public APIs as experimental, but since we're merging to an integration branch, I think it's ok to add that later only if needed.
There was a problem hiding this comment.
I'll add some API tests! As for marking them as experimental, I think the plan is to not do that for now, keep merging into the dev branch, and then create a beta release for the first few customers who use the Galaxy store.
tonidero
left a comment
There was a problem hiding this comment.
Looks good! I think only removing the proguard rules for now, and we can readd them later if we think it's needed.
Description
This PR creates a new module for the Galaxy Store, and allows developers to set up the Android SDK to use the Galaxy Store when they configure the SDK, like so:
It also:
GalaxyBillingMode, an enum required when configuring the SDK to use the Galaxy Store, which determines the environment that the Galaxy Store processes IAPs with (prod, test, etc.).BillingFactorywill wire up aGalaxyBillingWrapper