Fix CoroutineCreationDuringComposition lint error on AGP 8.13.0#2659
Merged
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
Coverage 78.09% 78.09%
=======================================
Files 306 306
Lines 11484 11484
Branches 1590 1590
=======================================
Hits 8968 8968
Misses 1819 1819
Partials 697 697 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonidero
approved these changes
Sep 9, 2025
Thanks for doing this!| val colorScheme = MaterialTheme.colorScheme | ||
| val isDark = isSystemInDarkTheme() | ||
|
|
||
| LaunchedEffect(colorScheme, isDark) { |
Contributor
There was a problem hiding this comment.
This is good! I wonder if we could remove the checks we do on the refreshStateIfColorsChanged method that check that the values haven't changed after this change... but I guess they won't hurt either so FFTI.
Member
Author
There was a problem hiding this comment.
nice! I will make the change now, otherwise I will forget lol
tonidero
pushed a commit
that referenced
this pull request
Sep 10, 2025
Fixes #2588 (comment) A new lint issue that starts happening when upgrading to AGP 8.13.0 Also wrapped the `refreshStateIfColorsChanged` in a LaunchedEffect keyed by the inputs, so it only runs when the theme actually changes.
Closed
tonidero
pushed a commit
that referenced
this pull request
Sep 10, 2025
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add `RevenueCatBackupAgent` (#2625) via Toni Rico (@tonidero) ### 🔄 Other Changes * Fix CoroutineCreationDuringComposition lint error on AGP 8.13.0 (#2659) via Cesar de la Vega (@vegaro) * Support setting null offering id on PaywallView (#2658) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2588 (comment)
A new lint issue that starts happening when upgrading to AGP 8.13.0
Also wrapped the
refreshStateIfColorsChangedin a LaunchedEffect keyed by the inputs, so it only runs when the theme actually changes.