Rename TestStore to SimulatedStore#2591
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
==========================================
- Coverage 78.28% 78.28% -0.01%
==========================================
Files 299 299
Lines 11052 11059 +7
Branches 1537 1541 +4
==========================================
+ Hits 8652 8657 +5
+ Misses 1727 1726 -1
- Partials 673 676 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JayShortway
approved these changes
Aug 6, 2025
JayShortway
left a comment
Member
There was a problem hiding this comment.
Good stuff! Just a few minor suggestions.
Comment on lines
+26
to
+30
| const val SIMULATED_STORE_API_KEY = "Using a Simulated Store API key.\n" + | ||
| "The Simulated Store is for development only. Never use a Simulated Store API key in production. " + | ||
| "Our SDK will crash if using it in production. Simulated Store purchases are simulated, " + | ||
| "do not use Google Play or Amazon store, and generate no revenue. " + | ||
| "Apps submitted with a Simulated Store API key will be rejected during App Review." |
Member
There was a problem hiding this comment.
This message should probably still use the Test Store name, as it is "public communication"?
Comment on lines
+17
to
+19
| const val RESTORE_PURCHASES_TEST_STORE = "Restoring purchases not available in test store. " + | ||
| const val RESTORE_PURCHASES_SIMULATED_STORE = "Restoring purchases not available in simulated store. " + | ||
| "Returning current CustomerInfo." | ||
| const val SYNC_PURCHASES_TEST_STORE = "Syncing purchases not available in test store. " + | ||
| const val SYNC_PURCHASES_SIMULATED_STORE = "Syncing purchases not available in simulated store. " + |
Member
There was a problem hiding this comment.
Same here, these messages should still use "Test Store" I think?
ajpallares
approved these changes
Aug 6, 2025
ajpallares
left a comment
Member
There was a problem hiding this comment.
Looking great!
We just need to know the final public-facing name of the Store for the log messages before merging, as it's not clear to me either if we're going public with Test Store or Simulated Store
Contributor
Author
|
Going to merge this for now, but lmk if you think there are any other changes you would like to consider! |
This was referenced Aug 13, 2025
tonidero
pushed a commit
that referenced
this pull request
Aug 14, 2025
**This is an automatic release.** ## RevenueCat SDK ### 📦 Dependency Updates * [RENOVATE] Update dependency gradle to v9 (#2589) via RevenueCat Git Bot (@RCGitBot) ## RevenueCatUI SDK ### Customer Center #### ✨ New Features * Show a subscribe button in customer center when there are no subscriptions (#2596) via Facundo Menzella (@facumenzella) #### 🐞 Bugfixes * Fix title and price of non-Google purchases in Customer Center (#2576) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2598) via RevenueCat Git Bot (@RCGitBot) * Add alias users backend call (#2594) via Toni Rico (@tonidero) * Rename TestStore to SimulatedStore (#2591) via Toni Rico (@tonidero) * Fail configure call if using test api key in release builds (#2590) via Toni Rico (@tonidero) * Support test store (#2554) via Toni Rico (@tonidero) * Fix insets in Paywall Tester (#2584) via Cesar de la Vega (@vegaro) * Add 8.22.1 to CHANGELOG (#2582) via Toni Rico (@tonidero) * Add warning on V9 CHANGELOG (#2586) via Toni Rico (@tonidero) * Change metalava job to diff dump generated dump files (#2585) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
Rename to conform with new internal naming.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename to conform with new internal naming.