Fix promotional offer not being displayed#2173
Merged
Merged
Conversation
vegaro
commented
Feb 14, 2025
| } | ||
| } | ||
| return false | ||
| return loaded |
Member
Author
There was a problem hiding this comment.
I think I can refactor this to check if there's a promotionalOfferData in the state in the calling function, but I would need to do more tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
=======================================
Coverage 80.98% 80.98%
=======================================
Files 276 276
Lines 9388 9388
Branches 1333 1333
=======================================
Hits 7603 7603
Misses 1226 1226
Partials 559 559 ☔ View full report in Codecov by Sentry. |
vegaro
pushed a commit
that referenced
this pull request
Feb 15, 2025
**This is an automatic release.** ## RevenueCatUI SDK ### Customer Center #### 🐞 Bugfixes * Fix promotional offer not being displayed (#2173) via Cesar de la Vega (@vegaro) * Fix back button dismissing the Customer Center (#2171) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not returning the updated state when loading the promotional offer, so it was effectively never been set in the state