Uses Sequence instead of Stream to avoid errors due to unavailable Java 8 APIs#1943
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 260 260
Lines 8492 8493 +1
Branches 1226 1226
=======================================
+ Hits 6953 6954 +1
Misses 1041 1041
Partials 498 498 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Nov 28, 2024
tonidero
left a comment
Contributor
There was a problem hiding this comment.
This is great! Maybe just removing the required version annotations... Tested it and seems to work as expected 💪
| // This is using a lambda with a Sequence instead of returning the Sequence itself. This is so we keep | ||
| // the responsibility of closing the bufferedReader to this class. Note that the Sequence should | ||
| // be used synchronously, otherwise the bufferedReader will be closed before the Sequence is used. | ||
| @RequiresApi(Build.VERSION_CODES.N) |
Contributor
There was a problem hiding this comment.
I believe this is probably not needed anymore, as you mentioned over slack.
Member
Author
There was a problem hiding this comment.
Alright, will create a follow-up PR to clean these up if we decide they're not needed.
This was referenced Nov 28, 2024
JayShortway
pushed a commit
that referenced
this pull request
Dec 2, 2024
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Uses `Sequence` instead of `Stream` to avoid errors due to unavailable Java 8 APIs (#1943) via JayShortway (@JayShortway) ### 🔄 Other Changes * Increase integration test timeout (#1946) via Toni Rico (@tonidero) * Removes `@RequiresApi(N)` from `FileHelper` and related classes (#1944) via JayShortway (@JayShortway) * [Paywalls V2] Minimizes Java API (#1942) via JayShortway (@JayShortway) * [Paywalls V2] Makes `TextComponent` public (#1939) via JayShortway (@JayShortway) * Introduces an `@InternalRevenueCatAPI` annotation (#1938) via JayShortway (@JayShortway) * [Paywalls V2] Moves any non-component file to a new `common` package. (#1937) via JayShortway (@JayShortway) * [Paywalls V2] `LocalizationKey` is an inline value class now. (#1936) via JayShortway (@JayShortway) * [Paywalls V2] Adds `PaywallComponentsData` (#1935) via JayShortway (@JayShortway) * [Paywalls V2] Adds `StickyFooterComponent` (#1934) via JayShortway (@JayShortway) * [Paywalls V2] Adds `PurchaseButtonComponent` (#1933) via JayShortway (@JayShortway) * [Paywalls V2] Adds `PackageComponent` (#1932) via JayShortway (@JayShortway) * Ensure the correct error message is shown when failing to open a Uri in paywalls (#1922) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ButtonComponent` (#1931) via JayShortway (@JayShortway) * [Paywalls V2] Adds `StackComponent` (#1930) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ComponentOverrides` (#1929) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ImageComponent` (#1928) via JayShortway (@JayShortway) * [Paywalls V2] Adds `TextComponent` (#1927) via JayShortway (@JayShortway) * [Paywalls V2] Adds all enum properties (#1926) via JayShortway (@JayShortway) * [Paywalls V2] Adds `SizeConstraints`, `Size`, `Padding` and `Shadow` properties (#1925) via JayShortway (@JayShortway) * [Paywalls V2] Adds `CornerRadiuses`, `Shape` and `MaskShape` properties (#1924) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ImageUrls` and `ColorInfo` properties (#1923) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
2 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
### Description Originally we used streams which weren't supported in Android < 24, but that was removed in #1943 and #1944. However, we have some leftover code checking for the android version to create the events manager itself. This removes that, which makes events now available for older android versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Streamis a Java 8 API, which needs desugaring to function correctly across devices and API levels. This can lead to crashes such as RevenueCat/purchases-flutter#1213, which is only surfacing now because we fixed error-swallowing in #1894.Changes
Fortunately, Kotlin's
Sequenceis a near drop-in replacement forStream. This PR implements that replacement.