Handle IllegalArgumentException when opening a Uri in the paywalls#1904
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1904 +/- ##
=======================================
Coverage 82.30% 82.30%
=======================================
Files 231 231
Lines 8058 8058
Branches 1132 1132
=======================================
Hits 6632 6632
Misses 979 979
Partials 447 447 ☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Nov 7, 2024
tonidero
pushed a commit
that referenced
this pull request
Nov 8, 2024
**This is an automatic release.** ## RevenueCatUI SDK ### 🐞 Bugfixes * Handle `IllegalArgumentException` when opening a Uri in the paywalls (#1904) via Toni Rico (@tonidero) ### 🔄 Other Changes * Create sample web purchase redemption app (#1908) via Toni Rico (@tonidero) * Add extra error cases for web purchases redemptions (#1899) via Toni Rico (@tonidero) * Use new web redemption endpoint (#1903) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looking at the docs, the
openUrimethod, may throw anIllegalArgumentExceptionif the link is invalid.I haven't been able to reproduce this error, getting an
ActivityNotFoundExceptioninstead when the link is invalid... Seems this may be something device related. In any case, we should also handle these exceptions according to the docs and fail gracefully.