Detekt auto-fixes#1886
Merged
Merged
Conversation
JayShortway
approved these changes
Oct 22, 2024
JayShortway
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! I've seen these get applied on my end too, so maybe they were missed at some point.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
=======================================
Coverage 82.25% 82.25%
=======================================
Files 227 227
Lines 7968 7968
Branches 1121 1121
=======================================
Hits 6554 6554
Misses 967 967
Partials 447 447 ☔ View full report in Codecov by Sentry. |
tonidero
pushed a commit
that referenced
this pull request
Nov 4, 2024
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * [Experimental] Web purchase redemption (#1889) via Toni Rico (@tonidero) ### 🐞 Bugfixes * Keeps the org.json package. (#1891) via JayShortway (@JayShortway) ### 📦 Dependency Updates * Bump rexml from 3.3.8 to 3.3.9 (#1892) via dependabot[bot] (@dependabot[bot]) * Bump danger from 9.5.0 to 9.5.1 (#1885) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.224.0 to 2.225.0 (#1884) via dependabot[bot] (@dependabot[bot]) ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix application of modifiers in `Markdown` component (#1893) via Toni Rico (@tonidero) ### 🔄 Other Changes * [CI] Allow publishing snapshot releases manually from branches (#1888) via Toni Rico (@tonidero) * Detekt auto-fixes (#1886) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Detekt is applying these fixes for me, not sure why it's not applying them remotely... They seemed to make sense so I just applied them for now.