Avoid recreating purchases same config#1866
Closed
tonidero wants to merge 3 commits into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
- Coverage 82.37% 82.35% -0.03%
==========================================
Files 225 225
Lines 7900 7929 +29
Branches 1104 1119 +15
==========================================
+ Hits 6508 6530 +22
+ Misses 953 952 -1
- Partials 439 447 +8 ☔ View full report in Codecov by Sentry. |
e8cd5f1 to
5b57b16
Compare
tonidero
commented
Oct 7, 2024
|
|
||
| init { | ||
| this.context = builder.context | ||
| this.context = builder.context.applicationContext |
Contributor
Author
There was a problem hiding this comment.
I noticed we could potentially be leaking an activity if the developer gave us the activity context and we hold a reference to this object. So I changed it here so we only hold the application context, which is the one developers should normally give us.
tonidero
added a commit
that referenced
this pull request
Oct 8, 2024
…matically (#1872) ### Description In here we store the latest known state for `Purchases` so we can reconfigure when displaying the `PaywallActivity` and the SDK is not configured. This may happen if the app is killed while displaying the `PaywallActivity`, the developer is not configuring in the application but on an activity and the user returns through the app through the recent apps menu. Additionally, it includes the changes from #1866 so we avoid reconfiguring the SDK if the configuration parameters are the same.
Contributor
Author
|
Closing in favor of #1872 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This came from a conversation in Slack. I think we can limit the amount of multiple configuration issues if we don't reconfigure the SDK with the same parameters that were originally passed. I don't think there should be any use cases for that in any case? Keeping on hold to get feedback